Disable softdeleteable filter doesn't disabled Listeners #1175

Garfield-fr · 2014-10-14T14:55:36Z

I would like to hard-delete a record by disabling the filter but it doesn't work because listeners are already active on my entity.

I find a solution but it's not perfect:

$manager->getFilters()->disable('softdeleteable');
foreach ($manager->getEventManager()->getListeners() as $eventName => $listeners) {
    foreach ($listeners as $listener) {
        if ($listener instanceof \Gedmo\SoftDeleteable\SoftDeleteableListener) {
            $manager->getEventManager()->removeEventListener($eventName, $listener);
        }
    }
}

Do you have another solution ?

Thank's

gitomato · 2014-12-10T16:52:42Z

Hello, it may be a typo.
Can you try with :

$manager->getFilters()->disable('soft-deleteable');

https://github.com/Atlantic18/DoctrineExtensions/blob/master/doc/softdeleteable.md#setup-and-autoloading

Garfield-fr · 2014-12-23T12:51:44Z

doctrine:
        orm:
            entity_managers:
                default:
                    filters:
                        softdeleteable:
                            class: Gedmo\SoftDeleteable\Filter\SoftDeleteableFilter
                            enabled: true

and in my function

$em = $this->getContainer()->get('doctrine')->getManager();
$em->getFilters()->disable('softdeleteable');
...
$em->remove($user);
$em->flush();

The record is not deleted from my db, it's marked deleted with date and time. Disabled filter don't deactivated softdeletable listener.

Any solution ?

Thank's

appeltaert · 2015-10-19T14:55:32Z

same, doesnt seem fixed 1 year later? theres no way to disable them now. @Garfield-fr did you find a solution?

max-kovpak · 2015-10-20T09:31:43Z

You can create your own event listener something like this:

<?php namespace AppBundle\EventListener;

use \Gedmo\SoftDeleteable\SoftDeleteableListener as BaseSoftDeleteableListener;
use Doctrine\Common\EventArgs;

class SoftDeleteableListener extends BaseSoftDeleteableListener
{

    /**
     * @inheritdoc
     */
    public function onFlush(EventArgs $args)
    {
        $ea = $this->getEventAdapter($args);
        $om = $ea->getObjectManager();
        //return from event listener if you disabled filter: $em->getFilters()->disable('softdeleteable');
        if (!$om->getFilters()->isEnabled('softdeleteable')) {
            return;
        }

        parent::onFlush($args);
    }

}

in your config:

    gedmo.listener.softdeleteable:
        class: AppBundle\EventListener\SoftDeleteableListener
        tags:
            - { name: doctrine.event_subscriber, connection: default }
        calls:
            - [ setAnnotationReader, [ @annotation_reader ] ]

keksa · 2016-06-06T15:07:02Z

For anyone still wondering about this. It is possible to hard delete softdeleteable entity with provided listener by setting the deletedAt field to DateTime object.

So for example this would hard delete user entity:

$user->setDeletedAt(new \DateTime);
$em->remove($user);
$em->flush();

This code in Gedmo listener provides that:

$reflProp = $meta->getReflectionProperty($config['fieldName']);
$oldValue = $reflProp->getValue($object);
if ($oldValue instanceof \Datetime) {
    continue; // want to hard delete
}

cadavre · 2017-11-03T19:42:44Z

Wait a second...

$reflProp = $meta->getReflectionProperty($config['fieldName']);
$oldValue = $reflProp->getValue($object);
if ($oldValue instanceof \Datetime) {
    continue; // want to hard delete
}

Doesn't it mean that if you call $em->remove($entity) for a second time (on already soft-deleted entity) it will remove it from DB?

Deveosys · 2018-01-29T17:43:26Z

Exactly, it's up to you not to make the deletion actions available on soft deleted objects

l3pp4rd · 2018-01-29T18:40:49Z

there is an option now to prevent hard deletion on second call and any other, see the doc for softdelete

github-actions · 2021-11-25T09:05:00Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sdev-maxime · 2022-02-23T14:16:27Z

Update:

in SoftDeleteableListener.php

if (isset($config['hardDelete']) && $config['hardDelete'] && $oldValue instanceof \DateTimeInterface && $oldValue <= $date) {
    continue; // want to hard delete
}

So, configuration in entity file can be

/**
 * @ORM\Entity(repositoryClass=MyEntityRepository::class)
 * @ORM\Table(name="my_table_name")
 * @Gedmo\SoftDeleteable(fieldName="deletedAt", timeAware=false, hardDelete=true)  <==== SET hardDelete to true
 */
class MyEntity { ... }

Then, there is some new behaviors.

The first time you'll remove an entity, the entity fill deleteAt field and store/save in database : classic behavior of softdeleteable.
If you remove a second time the same entity (with configured hardDelete=true in entity file), the entity will be deleted in database, cause it was already soft-deleted and have deleted at field filled: hard delete behavior after soft delete (very cool).

$entity = new Entity();
$this->em->persist($entity);
$this->em->flush();
// create entity in database

$this->em->remove($entity);
$this->em->flush();
// Now entity has deletedAt field filled -> is soft-deleted

$this->em->remove($entity);
$this->em->flush();
// Now entity is hard deleted, no anymore in database.

How delete without removing twice ? just add new \DateTime() to deleted at field.

$entity = new Entity();
$this->em->persist($entity);
$this->em->flush();
// Here I have a new entity saved in database

$entity->setDeletedAt(new \DateTime());
$this->em->remove($entity);
$this->em->flush();
// Now entity is hard deleted, no anymore in database.   due to the DateTimeInterface condition on top off the topic.

Hope this will help =)

Garfield-fr changed the title ~~Disable softdeleteable filter doesn't disabled Listener~~ Disable softdeleteable filter doesn't disabled Listeners Oct 14, 2014

stephanvierkant added the SoftDeleteable label Apr 12, 2018

github-actions bot added the Stale label Nov 25, 2021

github-actions bot closed this as completed Dec 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

Disable softdeleteable filter doesn't disabled Listeners #1175

Disable softdeleteable filter doesn't disabled Listeners #1175

Garfield-fr commented Oct 14, 2014

gitomato commented Dec 10, 2014

Garfield-fr commented Dec 23, 2014

appeltaert commented Oct 19, 2015

max-kovpak commented Oct 20, 2015

keksa commented Jun 6, 2016

cadavre commented Nov 3, 2017

Deveosys commented Jan 29, 2018

l3pp4rd commented Jan 29, 2018

github-actions bot commented Nov 25, 2021

sdev-maxime commented Feb 23, 2022 •

edited

Loading

Disable softdeleteable filter doesn't disabled Listeners #1175

Disable softdeleteable filter doesn't disabled Listeners #1175

Comments

Garfield-fr commented Oct 14, 2014

gitomato commented Dec 10, 2014

Garfield-fr commented Dec 23, 2014

appeltaert commented Oct 19, 2015

max-kovpak commented Oct 20, 2015

keksa commented Jun 6, 2016

cadavre commented Nov 3, 2017

Deveosys commented Jan 29, 2018

l3pp4rd commented Jan 29, 2018

github-actions bot commented Nov 25, 2021

sdev-maxime commented Feb 23, 2022 • edited Loading

sdev-maxime commented Feb 23, 2022 •

edited

Loading