Skip to content

ImageField missing validation? #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lauraseidler opened this issue Dec 30, 2020 · 9 comments
Closed

ImageField missing validation? #4088

lauraseidler opened this issue Dec 30, 2020 · 9 comments

Comments

@lauraseidler
Copy link

Describe the bug
I'm using the ImageField like so:

ImageField::new('avatar')
    ->setUploadDir('public/uploads/avatars/')
    ->setBasePath('uploads/avatars')
    ->setUploadedFileNamePattern('[year]-[month]-[day]-[contenthash].[extension]')

This works, however I'm able to also upload files that are not images. I would be fine adding this validation manually, but I haven't really found a way to do so

To Reproduce
Install EA 3.2.0, use an ImageField like described above, and upload a file that's not an image
@parijke
Copy link
Contributor

parijke commented Dec 30, 2020

Do you check the mimetype?

@lauraseidler
Copy link
Author

How would I go about this? I tried adding constraints to my entity, but I could not make File or Image constraints work, since the field only holds the file path it seems.

@cristobal85
Copy link

You can do this with these annotations in yours entities:

  • For 1 image:
   /**
     * @ORM\Column(type="string", length=255, nullable=true)
     * @Assert\Regex(
     *     pattern="/^.*\.(jpg|jpeg|png|gif)$/i",
     *     match=true,
     *     message="............"
     *   )
     */
  • For several images:
    /**
     * @ORM\Column(type="array", nullable=true)
     * @Assert\All({
     *   @Assert\Regex(
     *     pattern="/^.*\.(jpg|jpeg|png|gif)$/i",
     *     match=true,
     *     message="........................................"
     *   )
     * })
     */

@parijke
Copy link
Contributor

parijke commented Jan 5, 2021

I have this (but using vich)

    /**
     * @Vich\UploadableField(mapping="policy_pdf", fileNameProperty="policy", mimeType="mimeType")
     * @Assert\File(
     *     mimeTypes = {"application/pdf"},
     *     mimeTypesMessage = "Only PDF's can be uploaded"
     * )
     * @var File
     */

@parijke
Copy link
Contributor

parijke commented Jan 5, 2021

and my field def:

        $policyFile = Field::new('policyFile')
            ->setFormType(VichFileType::class);

@lauraseidler
Copy link
Author

Both very helpful, thanks (apologies for the delayed response, I had to table this project for a while)!

I was indeed already using Vich before, so I don't really mind to keep using it, as I found it to work well for me, and I got it to work for single images just fine. Any ideas on how to make it work for multiple images @parijke? I'm thinking I might need to go the extra step here and do an Images entity, and then just associate them.

@parijke
Copy link
Contributor

parijke commented Feb 7, 2021

@lauraseidler https://www.youtube.com/watch?v=dKX_yREDOmQ&t=619s

@gaelb80 gaelb80 mentioned this issue Mar 31, 2021
Closed
@Seb33300
Copy link
Contributor

Same as #5227
I created a PR here: #6258

@Seb33300 Seb33300 mentioned this issue Apr 13, 2024
Merged
javiereguiluz added a commit that referenced this issue May 21, 2024
@javiereguiluz
feature #6258 [ImageField] Support constraint validation (Seb33300)
1fdacd6 
This PR was squashed before being merged into the 4.x branch.

Discussion
----------

[ImageField] Support constraint validation

Fixes #5227 and #4088

Currently, it is not possible to properly validate images uploaded with the `ImageField` using Symfony constraints.
This is because the `constraints` option is applied to both the parent field (returning a `string`) and the underlying `FileType` field (returning an `UploadedFile`) resulting in unexpected validation errors.

This PR adds a new `setFileConstraints` method to the `ImageField` to apply constraints to the `FileType` field only.
By default, I also applied the [`Image`](https://symfony.com/doc/current/reference/constraints/Image.html) constraint on the `ImageField`.

Usage example:

``` php
use Symfony\Component\Validator\Constraints\Image;

// Validate that file is an image by default
ImageField::new('logo', 'Logo'),

// Set custom validation constraints
ImageField::new('logo', 'Logo')->setFileConstraints(new Image(maxSize: '100k')),
```

Commits
-------

76a9e9d [ImageField] Support constraint validation
@javiereguiluz
Copy link
Collaborator

Closing as fixed in #6258.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @Seb33300 @parijke @cristobal85 @lauraseidler