-
Notifications
You must be signed in to change notification settings - Fork 183
Symfony 4 support #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For anyone who's interested, I've got the bundle working in Symfony 4 in a very 'hacky' way. See the basic installation instructions on how to get bundle overrides for templates working in Symfony 4 with this, that was the only major hurdle I had after changing the installation requirements and renaming template locations to match Symfony 4. |
I need it too :) Hacky way from @hairybobbins don't work for me, composer can't resolve paths. |
@kubaceg Can you post the full error message from composer please? |
Hi, from user entity
I'm thinking now that probably after my changes in composer.json (repository + new bundle) and composer install command nothing happens. I must check it once again |
@kubaceg It looks to me like your application is failing before it reaches composer, it might be worth commenting out that reference then seeing if it works. |
@kubaceg hey, just realised that
if you're experiencing issues, run |
Thanks! I'll try it :) |
It works fine :) only what I have to do was add own entities mapping in yaml + define aliases:
|
@kubaceg good spot, I'll add these notes to the install instructions on my fork later cheers! |
@hairybobbins I'm using your fork but it's giving the service error The "fos_message.provider" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead. |
It ran when I put the services as public in the class Ex.: class FOSMessageExtension extends Extension
{
//...
$container->setAlias('fos_message.message_manager', new Alias($config['message_manager'], true));
//...
} |
@hairybobbins I just submitted a pull request to your fork implementing the fix by @afranioce for all the Aliases. |
Thanks for all the suggestions. I used these to get the bundle to work, but now I can't get it to use my custom twig templates. In Symfony 4 they should be placed in /templates/bundles/... Unfortunately, this does not work at all. Any suggestions? |
@finkbg Also make sure to tell twig about the path (last step from "~/vendor/friendsofsymfony/message-bundle/FOS/MessageBundle/Resources/doc/01-installation.md")
|
Just seen this thread guys (really wish github had a notifications bar, or if it does I wish I could find it :') ) I've got some time free next monday and over the weekend, so I'll have a look at the fixes you've both suggested @ChanOmegaWebDesign @afranioce Cheers! |
@ChanOmegaWebDesign Thanks, changing the extend path worked for me. For whatever reason (3.4 legacy?) the extend path in the files was FOSMessageBundle::layout.html.twig and it pointed at the vendor path instead of templates/bundles/.... |
Pull request now approved and merged @ChanOmegaWebDesign |
@finkbg Can you provide us with your Message entity? The only suggestion I can offer without that is to make sure you've included |
@finkbg as @kubaceg has mentioned previously, you might also need to map your entities in your config file |
I accidentally deleted the original post: Basically, it said that the App/Entities did not work. Actually, they are working, we were wrongly trying to use a setter when initially creating the thread with $composer->newThread(). This seems a bit confusing, as $composer->newThread() returns an instance of Entity/Message instead of Entity/Thread. We figured it out. However, we are having a separate issue when serializing the Thread Entity with JMS Serializer. For some reason the @expose rules in the App/Entity/Thread are being ignored. |
@hairybobbins would you like to take over this bundle's maintainance? I actualized things a bit in #329 but I won't be able to do much more... Otherwise without a maintainer we will likely deprecate this bundle :/ |
Symfony 4 support added in #329 😄 |
@GuilhemN hey man, completely missed this e-mail happy to take over maintenance of the bundle (if the offer is still available) as there are some mods I've made to a project of mine that might be handy to the bundle in general |
Also to everyone using my fork, I've changed my username to hex333ham (professional reasons), make sure to update your composer accordingly |
No problem, the offer is still available of course ;) |
Great bundle sûre i will give a try. |
Need add Symfony 4 support
The text was updated successfully, but these errors were encountered: