-
Notifications
You must be signed in to change notification settings - Fork 323
Closed
Description
Hi,
is it planned to ensure compatibility with Symfony 5 ?
Here is the result when activating the bundle :
Too few arguments to function Symfony\Component\Config\Definition\Builder\TreeBuilder::__construct(), 0 passed in \vendor\knplabs\doctrine-behaviors\src\Bundle\DependencyInjection\Configuration.php on line 12 and at least 1 expected
Thanks for the feedback.
Metadata
Metadata
Assignees
Labels
No labels
Activity
TomasVotruba commentedon Dec 19, 2019
Hi,
could you try latest alpha version?
It has lot of BC breaking changes, but it should be compatible with Symfony 5.
nicolashachet commentedon Dec 19, 2019
Thanks for your reply.
I tried this in composer.json :
But the requirements can't be resolved :
Any idea ?
TomasVotruba commentedon Dec 19, 2019
This should be resolved with
v2.0.0-alpha3
. Could you try it?nicolashachet commentedon Dec 19, 2019
Thanks, composer update is OK with alpha3.
I'll try use the bundle tomorrow.
TomasVotruba commentedon Dec 19, 2019
Great, thanks for confirmation 👍
Working on a an upgrade path now:
https://github.com/KnpLabs/DoctrineBehaviors#upgrade-1x-to-2
laurentHCM commentedon Dec 20, 2019
Hello Tomas,
Thanks for your job. I will also test.
I tried the upgrade process and there is a side effect by using this command
vendor/bin/rector process src --config vendor/knplabs/doctrine-behaviors/upgrade/rector/doctrine-behaviors-20.yaml
If we use a fullname as return signature for a function , the full name is changed ( in fact all full names are changed) but in many case like when using Stripe, you have a Customer entity and Stripe has also a customer entity so we have to fully qualify the name
TomasVotruba commentedon Dec 20, 2019
Hi,
the import issue should be solved by: rectorphp/rector#2459
If not, please provide minimal PHP code so I can replicate the bug
laurentHCM commentedon Dec 20, 2019
TomasVotruba commentedon Dec 20, 2019
Yea, we need to complete that migration rule to Rector.
How does your normal id property in an entity looks like?
laurentHCM commentedon Dec 20, 2019
TomasVotruba commentedon Dec 20, 2019
Could you show me
CategoryTranslation
as well?laurentHCM commentedon Dec 20, 2019
TomasVotruba commentedon Dec 20, 2019
I see. That's all I need, I'll prepare the migration rule during today
laurentHCM commentedon Dec 20, 2019
nicolashachet commentedon Dec 20, 2019
Hi,
I tried successfully following behaviours :
Thanks for your work !
TomasVotruba commentedon Dec 23, 2019
I've updated the upgrade set with @Orm\Id property completion to the entity.
Could you retry the run?
rector/rector
dev-master is neededlaurentHCM commentedon Dec 24, 2019
TomasVotruba commentedon Dec 24, 2019
Wow, that's great to hear.
Have a great xmass too!
laurentHCM commentedon Dec 25, 2019
TomasVotruba commentedon Dec 25, 2019
Hi Laurent,
good point. I was thinking about it, but didn't get to real work.
Will be handled here: rectorphp/rector#2479
TomasVotruba commentedon Jan 1, 2020
Closing as Symfony 5 is on.
For any new issues, just create a new issue here.
Thank you ❤️