-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add symfony 5 compatibility #252
Conversation
Lib was merged today |
Is the failing travis build the only issue to keep this PR from being merged? Build fails for Symfony5 on php7.3 ... |
I think that travis configuration should be updated, since Symfony 5 is stable |
@zairigimad @weaverryan I't enough to simply rerun the tests to pass, since lib dependencies have been adjusted. We could also test against PHP 7.4 now. |
ping.... |
I dont know why im getting this error on install KnpSnappyBundleProblem 1 |
@nawatend KnpSnappyBundle is not yet compatible with Symfony 5, apparently the tests just need to be reran so this pull request can be merged. I don't know who can do it though |
Sorry for the delay! Thank you @zairigimad! I'm going to check the test suite and see if we need any other updates before making a tag. |
Hmmm.. Still not working with symfony 5
|
It seems you are trying to install Snappy bundle v1.8.0 which is only compatible with Symfony >= v5.1 on a project with Symfony 5.0. |
#hackdayParis
this PR depends on KnpLabs/snappy#376