-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Symfony 5 #122
Comments
+1 |
Theres occurring a problem. But the Twig/Extensions Bundle is abandoned. The function, that this bundle here is using isn't in the Twig Core Extra extension: Has anybody a solution how to make this bundle (or a similar bundle) compatible? |
Really, timeago.js may be part of the solution here. But I'm unclear on what the best practices are using Webpack Encore and requiring a javascript library in a bundle. What I've been doing is
Then
Any idea on how to require a js library from within a Symfony Bundle, and integrate it (automatically?). Then the twig extension becomes easy, at least for that part. |
|
Thats because you need to install twig extension bundle (composer require twig/extensions) But Twig Extension Bundle is incompatible with SF5 ("Your requirements could not be resolved to an installable set of packages.") So this knp time bundle can't be installed right now. |
Should be better in v1.11.0. If you have any problems, please open a new issue :) |
Symfony5 is out, not sure what's needed to update this bundle. My attempt to simply bump the dependencies didn't work, can we drop PHP5 support?
Also, I think symfony/templating has been deprecated in favor of twig/twig, but I'm not sure how to provide BC for this.
The text was updated successfully, but these errors were encountered: