…openapi

[OpenApi] [Oauth] Fix render oauth when using OpenApi v3

… slashes

fix getClassType with no readableLink

…t-escaping-slashes

Ensure that `api:openapi:export` produces JSON with unescaped forward slashes

…on_2_5

fix(documentation): Fix DataTransformerInterface documentation

…ry-readblelink

Revert "fix getClassType with no readableLink"

Add date interval to type factory

…HERE <identifier = ..." to improve performance

…zation

Co-Authored-By: Alan Poulain <contact@alanpoulain.eu>

Co-Authored-By: Teoh Han Hui <teohhanhui@gmail.com>

…resources

Improve subresources DB query performance by removing a subquery

Upgrade phpstan to v0.12

Don't mention v2.5.5 in CHANGELOG as it does not exist yet

Rename a method in fixture class to avoid "getter" false positive

…ption-type

Fix wrong exception class thrown by ValidatorInterface

…`, `?object` and `?type`

The previous version of the `TypeFactory` generated following **WRONG** definitions:

 * `null|T[]` as `{"type": array, "items": {"type": "T"}}`
 * `?T[]` as `{"type": array, "items": {"type": "T"}}`
 * `array<string, T> as `{"type": array, "items": {"type": "T"}}`
 * `object` without explicit schema definition as `{"type": "string"}`
 * `?T` as `{"type": T}`

The new definitions instead do fix this by mapping:

 * `array<string, T>` as `{"type": "object", "additionalProperties": {"type": "T"}}`
 * `array<string, ?T> as `{"type": object, "additionalProperties": {"type": ["T", "null"]}}`
 * `null|array<string, T>` as `{"type": ["object", "null"], "additionalProperties": {"type": "T"}}`
 * `array<int, T>` as `{"type": "array", "items": {"type": "T"}}` (not very precise, but list support is not yet in symfony)
 * `object` without explicit schema definition as `{"type": "object"}`
 * `?T[]` as `{"type": "array", "items": {"type": ["T", "null"]}}`
 * `null|T[]` as `{"type": ["array", "null"], "items": {"type": "T"}}`

These annotations were too specific, since the returned type would never match anyway.

Specifically, psalm cannot yet declare `ArrayType1&ArrayType2`, so an union type of two
arrays is not currently something we can declare explicitly.

Ref: #3402 (comment)

As per OpenAPI documentation at https://swagger.io/docs/specification/data-models/data-types/
the OpenAPI v3 documentation does not allow defining union
types via `type: ['string', 'integer']`, but requires explicit
usage of `oneOf` and nested type declarations or references
instead.

Ref: #3402 (comment)

…I v2

OpenAPI V2 has no way to generate accurate nullable types, so we
need to disable nullable `oneOf` syntax in JSON-Schema by providing
some context to the `TypeFactory` when not operating under OpenAPI
v3 or newer considerations.

In future, Swagger/OpenAPIV2 will (finally) at some point disappear, so
we will be able to get rid of these conditionals once that happens.

…nAPI 3.0

OpenAPI 3.1 is not yet released, but fixes nullability in
the way we had fixed it before (via `{"oneOf": [{"type": "null"}, ...]}`) in
OAI/OpenAPI-Specification#1977.

Until OpenAPI 3.1 is released, things like ``{"type": ["integer", "null"]}` are
not valid definitions (because `"null"` is not yet a recognized type).

We'll stick to OpenAPI 3.0 for now, using:

 * `{"nullable": true, ...}` for simple types
 * `{"nullable": true, "anyOf": [{"$ref": ...}]}` for type references

…": "string"}`

To avoid BC breaks, we defer this fix to #3403

> **API Platform version(s) affected**: 2.5.x
>
> **Description**
>
> In our tests for `TypeFactory`:
>
> ```
>
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT)];
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
>
> // ...
>
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
>         yield [['type' => 'string'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
> ```
>
> While reviewing #3402, @dunglas found a potential BC break with objects that may be used in URIs as `string`s (therefore not `objects`):
>
>     * [#3402 (comment)](#3402 (comment))
>
>     * [#3402 (comment)](#3402 (comment))
>
>
> **How to reproduce**
>
> The test should instead convert `object` to `object`:
>
> ```
>
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT)];
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true)];
>
> // ...
>
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, false, Dummy::class)];
>         yield [['type' => 'object'], new Type(Type::BUILTIN_TYPE_OBJECT, true, Dummy::class)];
> ```

Ref: #3402 (comment)

Ref: #3402 (comment)

…a::getVersion()

…tions-for-nullability-and-nested-structures

Corrected schema generation for `array<string, T>`, `object`, `?array`, `?object` and `?type`

symfony/symfony#35596

Move legacy integration tests to separate CI jobs
Bump CI jobs to use PHP 7.4 by default

Continue on error when it doesn't affect correctness of the job

Bump CI to check Symfony 5.1 compatibility

by its interface

Don't typehint the SchemaFactory decorator by its implementation, but by its interface

I had an issue where nested properties / classes didn't show up on OpenApi / Swagger docs (#2868).
With this PR the issue seems to be solved as the PropertyMetadataFactory gets the options. Thanks to @teohhanhui for the help on this.

… groups

Pass $options to PropertyInfoMetadataFactory

The result cache is a huge win.

CircleCI takes a very long time saving /tmp/phpstan/cache for some reason,
and this cache doesn't affect the run time much anyway.