-
-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate access_control attribute, add security + security_post_denormalize attributes #2992
Conversation
vincentchalamon
commented
Aug 19, 2019
•
edited
Loading
edited
Q | A |
---|---|
Waiting for PR? | #2990 |
Bug fix? | yes |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #1646, api-platform/api-platform#1218 |
License | MIT |
Doc PR | api-platform/docs#859 |
7ca234d
to
d58a96a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add a legacy test for access_control
?
If we're really doing this, I'd suggest: "access_control"={
"precondition"="...",
"postcondition"="...",
}, |
d58a96a
to
4665e2c
Compare
Sub-attributes are too verbose, I prefer this approach (see my comment in the related issue). |
4665e2c
to
77fc7f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once tests pass 👍
We need to dig through older issues, I'm sure that this solves more then 2 issues :p.
8e6dcb2
to
558971f
Compare
558971f
to
7b61c47
Compare
"security" and "late_security" are really confusing names. If you don't want nested attributes, then perhaps:
Or:
The second option would fit nicely with my suggestion of renaming I don't buy the argument that Symfony uses the term "security" too. It's not related to our case. |
ec43f9e
to
e354287
Compare
d57a903
to
4725000
Compare
d265e42
to
705fd64
Compare
705fd64
to
1f06b4e
Compare
Awesome! Thanks @vincentchalamon |
Hello,
|
|
Ok thank you, i'll do that. |