don't use eventName as parameter and variable #1393
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like having the |
mtdowling
added a commit
that referenced
this pull request
Feb 8, 2016
don't use eventName as parameter and variable
This was referenced May 9, 2016
This was referenced Oct 26, 2016
|
This fix seems to be present in the 5.3.1 release only: $ git tag --contains fcae91ff31de41e312fe113ec3acbcda31b2622e
5.3.1Shouldn't it be also merged to |
|
Guzzle 6 is middleware based, there are no events anymore. |
|
I see, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
$eventNamefor both as function parameter and in theusestatement will fail on PHP 7.1 with a message like "Cannot use lexical variable $eventName as a parameter name" (see symfony/symfony-installer#237).There also is a test in the test suite for PHP 7.1 ensuring that such a fatal error is triggered: https://github.com/php/php-src/blob/master/Zend/tests/closure_use_parameter_name.phpt