Closed

Description
Not an issue, just an inquiry,
Google is shutting down the Google+ API on March 7, 2019. Will this bundle be affected by this change? https://developers.google.com/+/api-shutdown
Not an issue, just an inquiry,
Google is shutting down the Google+ API on March 7, 2019. Will this bundle be affected by this change? https://developers.google.com/+/api-shutdown
Activity
weaverryan commentedon Jan 31, 2019
I have no idea :). It won't affect this bundle, but it may affect the actual library that talks to Google's OAuth. Here's a commit I found on that library: thephpleague/oauth2-google@8ce837d
Cheers!
fdiedler commentedon Feb 11, 2019
If anyone has the answer to this question, please tell :)
But, we will know the answer on March 7, 2019.
Thanks
weaverryan commentedon Feb 11, 2019
As long as you're using version 3.0 or higher of
thephpleague/oauth2-google
, I think you're fine - as they have removed the old functionality in that version (so there is now way to use that version and get things working by relying on the functionality that will be removed).ghost commentedon Feb 11, 2019
I'm not very familiar with Google Sign in API, but I think you guys maybe should change some parameter names. As I see, they are dropping the names
{google-app-id}
and{google-app-secret}
and using [OpenID Connect][openid-connect].also
Excuse me if i'm mistaken!
weaverryan commentedon Feb 14, 2019
Yes, but both ultimately are mapped to the
clientId
andclientSecret
params passed to the library - thephpleague/oauth2-google@8ce837d#diff-04c6e90faac2675aa89e2176d2eec7d8R57Basically, I think that a user of the
thephpleague/oauth2-google
library may need to make some changes to get v 3.0 to work with openid - getting a Google client ID / secret etc. Then you will use these values for theclient_id
andclient_secret
params in this bundle. This bundle doesn't have anything aboutgoogle-app-id
or anything similar - you can see all the options here:oauth2-client-bundle/src/DependencyInjection/Providers/GoogleProviderConfigurator.php
Lines 43 to 67 in aa5e8e5
Cheers!
fdiedler commentedon Feb 15, 2019
I found this link :
thephpleague/oauth2-google#63
It looks like everything is okay and the bundle has been updated but not really sure.
Thanks