Closed
Description
Hi,
please see comment from https://github.com/Seldaek in which relates to . Seems additional checks are required.
Type of ca-bundle is "library" and not "symfony-bundle"
Thanks
Rico
Metadata
Metadata
Assignees
Labels
No labels
Activity
andrew-demb commentedon May 15, 2020
Flex now try to auto discover bundle classes not only for
symfony-bundle
packages.Ref #612
sstok commentedon May 16, 2020
FYI. If you need something to keep your (use an) CA bundle up-to-date have a look at https://github.com/paragonie/certainty/ 👍
drupol commentedon May 26, 2020
In the meantime, to fix the issue, constraint
symfony/flex
version to1.6.2
.weaverryan commentedon May 27, 2020
I can confirm this. To repeat:
And then the error:
Ping @SerheyDolgushev do you have any ideas on how this might be fixed?
Btw - this is affecting
blackfire/php-sdk
, as it requirescomposer/ca-bundle
.stof commentedon May 27, 2020
The new detection of bundle classes in any package type might require adding a validation that the detected class is actually a class implementing the Symfony BundleInterface, and not a random class with a name ending with
Bundle
.Making the assumption that a class ending with
Bundle
in asymfony-bundle
package is actually a Symfony bundle could be considered OK. But removing the restriction on the package type makes it much harder to justify this.If we decide we don't want to implement such validation because broken cases would be very few, we could probably solve it by adding an explicit recipe for
composer/ca-bundle
forcing to define an empty array of bundle classes (which will disable the automatic detection).fabpot commentedon May 28, 2020
See #627
bug #627 Fix bundle auto-detection (fabpot)
fabpot commentedon May 28, 2020
I've just tagged 1.7.1 with the fix.
Merge pull request symfony#622