Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a maker for Doctrine migrations #1

Closed
fabpot opened this issue Nov 8, 2017 · 4 comments
Closed

Add a maker for Doctrine migrations #1

fabpot opened this issue Nov 8, 2017 · 4 comments

Comments

@fabpot
Copy link
Member

fabpot commented Nov 8, 2017

No description provided.

@fabpot
Copy link
Member Author

fabpot commented Nov 9, 2017

Just to be clear, I'm just proposing to add a command that wraps doctrine:migrations:generate, so that we have some consistency. What about make:migration?

@stof
Copy link
Member

stof commented Nov 10, 2017

should we actually wrap doctrine:migrations:generate ? 99% of cases, I'm not using migrations:generate but migrations:diff, so that the new migration already contains the SQL generated by DBAL for the schema change (even though I need to tweak it after that, to add the migration of data).
The only case where I'm using the generate command is when I need a data-only migration (no schema change).

@weaverryan
Copy link
Member

I like the idea! But i would also wrap :diff. Heck, if there are no diffs, we could ask if they want to generate a blank file (and also add a —empty option)

@weaverryan
Copy link
Member

See #10

@fabpot fabpot closed this as completed Nov 18, 2017
@MichaelBrauner MichaelBrauner mentioned this issue May 16, 2021
Open
Vincz added a commit to Vincz/maker-bundle that referenced this issue Sep 15, 2022
@Vincz
Fix methodName as string when adding method
9f0fb3e 
`$method->name` is an instance of `PhpParser\Node\Identifier` and must be cast to string for the following operations. 
Related error:

````

  [TypeError]
  Symfony\Bundle\MakerBundle\Util\ClassSourceManipulator::methodExists(): Argument symfony#1 ($methodName) must be of type string, PhpParser\Node\Identifier given, called in /Volumes/x/
  dev/ae/anovol/vendor/symfony/maker-bundle/src/Util/ClassSourceManipulator.php on line 1036
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @weaverryan @stof