-
-
Notifications
You must be signed in to change notification settings - Fork 495
[easy-log-handler] remove recipe #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Instead of removing this FIXME ... what if we:
I created this package because log files were a mess for me ... but recently PhpStorm added syntax highlighting and other improvements to logs ... so I no longer need this package. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
Works for me, recipe is now removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
As advised in symfony/recipes#751
Here is the sidekick PR to merge+tag: symfony/debug-pack#11 |
Could you please elaborate why this is removed? |
This PR was merged into the master branch. Discussion ---------- Remove easy-log-handler As advised in symfony/recipes#751 Commits ------- 1f79abf Remove easy-log-handler
@javiereguiluz could you share with us the way you're going through logs with PhpStorm? It looks very interesting :-) 🙏 |
@B-Galati the best of all is that I don't do anything special :) What I tried to say in my previous comment is that in the past, PhpStorm showed logs as an endless stream of black & white text. I couldn't find anything there. But in recent versions, logs are shown like this (by default, no plugins installed): For me this is more than enough. The highlighting makes everything very easy to find. I know that the Monolog handler that we removed is a bit better sometimes because it formats some information in several lines, etc. But 95% of the times, PhpStorm is enough for me. That's why I suggested removing this. |
Thanks @javiereguiluz, super interesting 👍 (It was not working for me because I had Ideolog plugin enabled) |
For projects started before this release and using the EasyLogHandler from the official symfony/debug-pack, this will actually break the dev build after running I am also using the latest PhpStorm 2020.1 but I have no syntax highlighting on the logs, with our without Ideolog. |
@cristi-contiu I'm using PhpStorm 2019.3 and I haven't installed any plugin related to logs. In fact, I only have 4 custom plugins, so that's why I think this must be some built-in behavior: |
@javiereguiluz Thank you very much for your reply! In case anyone else has the same issue, watch out for File Types associated to the |
@ostrolucky Do you see the color scheme on the |
@cristi-contiu WDYM? If I have some sort of syntax highlighting in .env file? No, I don't |
@ostrolucky My bad, I thought that the As a test, I disabled all downloaded plugins and still got syntax highlighting for In my case, the |
@ostrolucky you might have Ideolog plugin installed. Interestingly, it will not detect the log format here, if I uninstall it, it starts working for me. |
@javiereguiluz maybe you know about this?
@fabpot otherwise?
This looks scary for now :)