-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
HttpFoundation 4.0.12 breaks the web debug toolbar #27726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The problem should disappear when updating |
@xabbuh but according to the issue report:
Is this correct? Was that method really removed in a patch version? |
Yes, that was an internal one. |
@nicwortel I've checked this and as @xabbuh and @nicolas-grekas said, this is sadly expected. As you can see in this line v4.0.11...v4.0.12#diff-6ea44a1c02e94a4394cbc7076fe26bbeL147 the removed method is marked as I'm afraid the only solution possible is to upgrade these two dependencies to the same version. We're closing this issue report for that reason. Thanks! |
@javiereguiluz if it is internal, then why is it used by another component? What is Symfony's policy on this? |
I don't know the fine print of this, but a quick review of our BC policy promise shows that none of it applies to anything marked as |
we may miss a "conflict" rule somewhere, but I would advise upgrading all components to 4.1.1 instead. |
@javiereguiluz but the mistake was on our side. The internal HttpFoundation method was used by HttpKernel, not by the user. |
Symfony version(s) affected: >=4.0.12, >=4.1.1
Description

After upgrading HttpFoundation to version 4.0.12 (due to a security issue reported by SensioLabs Security Checker), our web debug toolbar stopped working. Debugging this issue shows that there seems to be a mismatch between version 4.0.4 of HttpKernel and version 4.0.12 of HttpFoundation, because the method
hasBeenStarted
has been removed fromSymfony\Component\HttpFoundation\Session\Session
.This sounds to me like a BC break. I'm not sure if we are supposed to upgrade all symfony packages at the same time, but I think the
composer.json
ofsymfony/http-foundation
should at least contain aconflicts
entry. I realize that thehasBeenStarted
method was tagged as@internal
but apparently it was being used in other Symfony components.Apparently this affects the web debug toolbar, but not our actual application.
The same issue seems to occur with version 4.1.1.
How to reproduce
Have symfony/http-foundation on version 4.0.12 and symfony/http-kernel on a lower version. Open the web interface with the debug toolbar enabled.
Possible Solution
hasBeenStarted
methodconflicts
entry to thecomposer.json
of HttpFoundation, to point out the conflict with older versions of HttpKernelAdditional context

This screenshot shows the request made by the web debug toolbar:
Installed Symfony components with their versions (from

composer show symfony/*
):The text was updated successfully, but these errors were encountered: