I don't think it be a good idea,
there is many good bundles like https://github.com/phiamo/MopaBootstrapBundle for TB3.

@aitboudad I'm working on a simple integration of TB3. Therefore, as TW is almost a standard, IMHO we can add some optional layout into the twig bridge.

@lyrixx well if we will add TB3, I propose also to add:

• HTML Boilerplate
• Zurb Foundation

But the problem is that there are many versions, for example TB2.

@aitboudad Feel free to open a PR ;)

-1

+1

@aitboudad BTW, this code should not belong to a bundle, because it is not re-usable (in a silex application for instance).

+1

-1, this is something the community should be doing in contributed bundles, it does not belong into core imo

Like @wouterj said, I think this such implementation should be done by community in separated bundle (or something like that). It's not a twig bridge task to integrate Twitter Bootstrap with symfony form.

I dont get the negativity for adding this, how many are going to install a Bundle to get a template for the form component?

Currently there is two layouts, table and div adding theese are good usecases on how to customize the form layouts. Which IMO is a part of forms that are not documented that good.

Adding an opinionated thing to the core just because the docs are not good is a no-go imo. Then the docs should be improved instead.

And indeed, a package would be a better fit instead of a bundle. The core just needs to be as less opinionated as possible, which did go pretty well until this PR :)

Well i would not see a Bridge as a core thing. It is an extension for other libraries, none said it had to be php libraries, that is the same as saying we cant have a Doctrine bridge because we are opiniated about using Doctrine over Propel.

@henrikbjorn if we created a BootstrapBridge, you would not see me commenting with -1. This bridge is about implementing twig into Symfony, not twitter bootstrap.

+1

👍

Deciding if something like this belongs to the core is always tricky. But please, consider the following two pro-core arguments:

• There are 44 public Symfony2 bundles related to Bootstrap. If something is that popular and that needed in real-world applications, I guess it could go in the core (in my opinion, if there are more than 30 bundles to do something, then Symfony is lacking that feature).
• If Bootstrap theme is included in the core, there is no obligation to include themes for other CSS frameworks (as suggested by @aitboudad). Bootstrap is, by a huge distance, the most used and most popular framework (just look at the GitHub stars, watchs and forks). In practice, Bootstrap has become as standard as designing with <div> and <table>, the other two existing form themes.

👍

Can't agree more with Javier!

@lyrixx you should add "twbs/bootstrap" in composer suggested packages.

@aitboudad ohh please no. There are already waaayyy too many suggested packages and it have no value (only the very first time a package is installed).

👍

-1

@javiereguiluz as a matter of facts, there are 33 bundles related to jQuery, 32 about payment, 67 about admin generators/interfaces, 38 about caching, 39 are shop/cart related, etc. Symfony core will get pretty big this way 😉

-1

For the same reasons @wouterj mentioned (and more useful/general things have been rejected to keep the core clean).

@lyrixx well, bundle templates/resources/code are reusable into silex. They just aren't auto discovered and you can't register its bundle.

@henrikbjorn there is aslo a propel1 bridge because it has been decided to officially support it.

So the question is to know if symfony officially supports bootstrap, in which case having a form theme as a bridge makes sense.

@wouterj yes, there are a lot of bundles for a lot of things: if jQuery bundles are just for including it, they are unnecessary (thanks to grunt, bower, requireJS); payments/cart/shop bundles are too specific (useful only for e-ecommerce sites); caching bundles are non-essential because Symfony resolves this problem well; 67 admin generator bundles is a clear proof that Symfony lacks a real generator, which is needed by everyone.

@hacfi the core isn't clean and it provides a lot of things that nobody needs, such as the percent and birthday fields and the IP and ISSN validators.

This discussion about Bootstrap reminds me the Apache discussion. A few years ago, Symfony decided to include a .htaccess file. It wasn't strictly necessary, but it was a nice addition for real developers solving real-world problems. And Symfony only included an .htaccess because Apache was at the moment the indisputable leader. A few years later Symfony is now evaluating if it's necessary to keep that file in the coming versions.

It would be nice to support Bootstrap-theme forms out-of-the-box without the need to install or configure anything.

-1
Adding support for only one css framework isn't good idea.
It's not a problem to add one file by developer to use bootstrap.

@MaksBaum Bootstrap is not "one CSS framework" but the most popular framework by a huge distance, the most popular project in GitHub history, and one of the projects that have revolutionized the frontend.

And don't forget that Symfony already has a lot of features aimed for only one product, service, or vendor:

• Symfony clearly prioritizes Doctrine over Propel and completely ignores any other ORM or ActiveRecord library.
• Symfony provides a .htaccess for Apache and provides nothing for Nginx and other web servers.
• Symfony only cares about PHP and Twig template engines and forgets about Smarty, Blade, etc.
• The credit card validator only validates a few selected card issuers.
• SwiftMailer provides a nice shortcut to send emails easily with Gmail, while ignoring any other web email provider.

I'm slightly in favor of adding this, for the reasons outlined by @javiereguiluz. However, why are you building a completely new Bootstrap theme here instead of building upon a tried and proven one from one of the various Bootstrap bundles out there?

I think there is a big misunderstanding here. We will not package bootstrap into Symfony. We will only include a form theme optimized for bootstrap.

-1

@fabpot @javiereguiluz @webmozart @henrikbjorn Create a Symfony Bridge for Bootstrap (not inside Twig) and I'm sure half of the complains are gonna disappear.

@guilhermeblanco 👍

The collection type seems to be missing from your examples? What about rendering a collection with rows using "inline" layouts?

@lyrixx Any feedback to that?

👍

The collection type seems to be missing from your examples? What about rendering a collection with rows using "inline" layouts?

@webmozart by inline, you mean horizontal ?

Anyway, indeed I forgot the collection type, But I added a sub-form. This is quit similar ;)

I will add more sample.

@lyrixx Cool, thanks! :)

@webmozart

vertical:

horizontal

main vertical collection horizontal

main vertical collection inline

main horizontal collection vertical

main horizontal collection inline

Thank you @lyrixx.

Awesome. If somebody uses Glyphicons or FontAwesome below example which replaces default list style to icon.

Replace:

{% block form_errors -%}
    {% if errors|length > 0 %}
    {% if form.parent %}<span class="help-block">{% else %}<div class="alert alert-danger">{% endif %}
        {{- parent() -}}
    {% if form.parent %}</span>{% else %}</div>{% endif %}
    {% endif %}
{%- endblock form_errors %}

With:

{% block form_errors -%}
    {% if errors|length > 0 -%}
    {% if form.parent %}<span class="help-block">{% else %}<div class="alert alert-danger">{% endif %}
    <ul class="list-unstyled">
        {%- for error in errors -%}
            <li><span class="glyphicon glyphicon-exclamation-sign"></span> {{ error.message|trans({}, translation_domain) }}</li>
        {%- endfor -%}
    </ul>
    {% if form.parent %}</span>{% else %}</div>{% endif %}
    {%- endif %}
{%- endblock form_errors %}

Before:

After:

@Macsch15 you should create a PR for this.

PR: #12164

I'm wondering if there's any tutorial on how can i add this using Silex? Or any tutorials that implement something similar to this project into Silex?

@simplynice25 The documentation is coming ;)

@lyrixx thanks! Will wait! :D

Thanks for this PR ! yeah for pragmatic.

-1,
Echoing "this is something the community should be doing in contributed bundles, it does not belong into core imo"

We had a very similar and long discussion in Drupal 8 core issue queue:
https://www.drupal.org/node/1801582

@joelpittet it does not make sense to start the discussion again. The code is merged and the decision is made.

Maintainers, this may be a good issue to lock?