[FrameworkBundle] Fix about command not showing .env vars #33357
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berezuev
suggested changes
Aug 27, 2019
weaverryan
reviewed
Aug 28, 2019
nicolas-grekas
approved these changes
Aug 30, 2019
fabpot
approved these changes
Aug 30, 2019
|
Thank you @brentybh. |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2019
…(brentybh) This PR was squashed before being merged into the 4.3 branch (closes #33357). Discussion ---------- [FrameworkBundle] Fix about command not showing .env vars Before this fix, `bin/console about` can't properly show `Environment (.env)` section because: `SYMFONY_DOTENV_VARS` which stores all keys of Dotenv-set env vars, is being fetched via `getenv()`. However, in Symfony Dotenv 4.3, usage of `putenv()` is deprecated: symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334 so we can get env vars via `getenv()` only when `new Dotenv(true)`. In the default shipped `config/bootstrap.php`, there is `new Dotenv(false)` set. (Maybe related #29131) | Q | A | ------------- | --- | Branch? | 4.3 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- f48f19d [FrameworkBundle] Fix about command not showing .env vars
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix,
bin/console aboutcan't properly showEnvironment (.env)section because:SYMFONY_DOTENV_VARSwhich stores all keys of Dotenv-set env vars, is being fetched viagetenv().However, in Symfony Dotenv 4.3, usage of
putenv()is deprecated:symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334
so we can get env vars via
getenv()only whennew Dotenv(true).In the default shipped
config/bootstrap.php, there isnew Dotenv(false)set.(Maybe related #29131)