Skip to content
This repository was archived by the owner on Apr 2, 2018. It is now read-only.
This repository was archived by the owner on Apr 2, 2018. It is now read-only.

Social Login not collecting user info #20

@sagivf

Description

@sagivf

Most auth systems collect the social providers user data (name, email at times, etc...).
At least for google it doesn't seem to do so.

Activity

imhoffd

imhoffd commented on Jul 10, 2016

@imhoffd
Contributor

@sagivf -- @Devnetics is actually working on this right now. None of the current social providers are collecting additional information. This was a known limitation that we are now addressing. I'll keep this open to inform you when you can expect this functionality.

IndyJones72

IndyJones72 commented on Jul 13, 2016

@IndyJones72

@dwieeb - Ok so even though this was for Google, we'll at the very least hopefully have this information for Google, Facebook and Twitter?

changed the title [-]Google Login not collecting user info[/-] [+]Social Login not collecting user info[/+] on Jul 13, 2016
imhoffd

imhoffd commented on Jul 13, 2016

@imhoffd
Contributor

@IndyJones72 Yes! I changed the title so it is more fitting.

sagivf

sagivf commented on Jul 17, 2016

@sagivf
Author

@dwieeb I've been wondering - will the platform do some sort of unification of the same person with different social logins or will each one create a new user in the system?

Not sure myself which is better, I'm guessing they could be unified based on the email. Probably best if it were configurable.

imhoffd

imhoffd commented on Jul 17, 2016

@imhoffd
Contributor

@sagivf Unification of users is actually pretty complex. Even once you're sure they're the same person (via email, for example), merging data and avoiding data destruction is a complicated process. Not all social networks give us email addresses and most don't give enough general data to piece things together.

But honestly, I don't see logins being merged. If a user shares an email address in two social networks and logs in to your app with one network then the other, they would expect to have a completely new account, not their data from the other. Best to keep them as separate accounts.

That being said, data analysis on users can be done while maintaining the two separate accounts. This is something we're interested in looking at later. But, obviously there's much to do before that.

sagivf

sagivf commented on Jul 17, 2016

@sagivf
Author

@dwieeb I agree with all of what you say.
Take into consideration that there are use cases were you want a user to sign in one way. then validate his email, then add social logins for all sorts of info from the social provider.

This is defiantly not a common use case for apps and not necessary to do with authentication, but it's good to keep in mind.

imhoffd

imhoffd commented on Jul 17, 2016

@imhoffd
Contributor

@sagivf Ah, yeah. Not a use case we'd tackle with our authentication. Devs are free to add those additional hookups themselves and then save such information in users' custom data. I would say it's not in our scope to add support for that, something which could be done with plugins such as cordova-plugin-facebook4 or libraries.

jaspervanveghel

jaspervanveghel commented on Aug 5, 2016

@jaspervanveghel

Are there any updates to report on the approximate completion date of this yet? We would like to integrate this into our app, which we'd like to release at the end of this month.

olivercodes

olivercodes commented on Aug 5, 2016

@olivercodes
Contributor

@jaspervanveghel This will be released by the end of next week. I'll update here when it's live.

IndyJones72

IndyJones72 commented on Aug 5, 2016

@IndyJones72

@Devnetics - great news. We are also looking to release at the end of the month and this will be great to have

ghost

ghost commented on Aug 12, 2016

@ghost

@Devnetics did you have any news :) we also have a release but next month and give full facebook login with complete user data will be great!

olivercodes

olivercodes commented on Aug 12, 2016

@olivercodes
Contributor

Hey guys, we have the PR ready to go on the backend to support Oauth provider user data. We didn't want to turn on a fairly complex new feature Friday afternoon, so we're hitting the on switch Monday morning. I'll post here when it's live.

We are giving you access to the basic user details (such as username, email (when available), full_name, and profile_picture), and then also recorded a raw_data object that gives you access to any of the other data that that particular provider happens to return on the Users/Self endpoint (for example, Github returns things like location, created_at, hireable, followers, etc.).

Note: We are not providing access to the provider tokens, that is still under discussion.

65 remaining items

sagivf

sagivf commented on Aug 23, 2016

@sagivf
Author

@ArkangelB Just so you know, I've always had problems with ionic run ios usually doesn't work for me. I use the emulator or run it through xcode (xcode doesn't always run smoothly either).

sagivf

sagivf commented on Aug 23, 2016

@sagivf
Author

There are so many variables to this - Ionic cli version, cordova version, node version, ionic version, ios-deploy, ios-sim, os version, plugins, xcode version and probably more :)

ghost

ghost commented on Aug 23, 2016

@ghost

@sagivf haha it's the first time that i have problems with ionic run ios but i know what you mean, i just make a package just to know if facebook social object its working and it works so i'm happy 👍 now i can keep working with the next stage..

edjeezy

edjeezy commented on Aug 23, 2016

@edjeezy

Can i know when the 'updated' docs will be available ?

olivercodes

olivercodes commented on Aug 23, 2016

@olivercodes
Contributor

Facebook and Google fixes are live now, the null fields should be corrected. We also pushed out a fix where in some cases Google email wasn't getting fetched properly.

@edjeezy We're working as fast as we can to get the updated docs out. The wait shouldn't be too much longer.

edjeezy

edjeezy commented on Aug 23, 2016

@edjeezy

@Devnetics thank you for the hard work . Ionic is really a dream came thrue so keep on going .

olivercodes

olivercodes commented on Aug 23, 2016

@olivercodes
Contributor

@edjeezy Thanks! It means a lot to us to hear that.

ghost

ghost commented on Aug 23, 2016

@ghost

@Devnetics i have a question i can have the image from facebook like this

$scope.imgProfile ="http://graph.facebook.com/v2.7/{user.id}/picture"

and it get the same photo quality that the picture that you bring to the object but if you ask for this one

$scope.imgProfile ="http://graph.facebook.com/v2.7/{user.id}/picture?type=large"

it gets a much better quality, so my question is, it exist a way that we can ask for a better photo quality?

olivercodes

olivercodes commented on Aug 23, 2016

@olivercodes
Contributor

@ArkangelB I see what you mean. I'll look into it. The base url we provide from facebook doesn't give you that capability at the moment.

ghost

ghost commented on Aug 23, 2016

@ghost

@Devnetics ok this still works pretty nice!

Thanks for everything!

olivercodes

olivercodes commented on Aug 26, 2016

@olivercodes
Contributor

Hey guys, we are going to ahead and close this issue. We are still making small tweaks/updates, nothing breaking. We have taken into account all of the feedback and will be iterating on this feature further after release of the new docs. Please report any actual errors in a new issue.

cfjedimaster

cfjedimaster commented on Mar 6, 2017

@cfjedimaster

Just checking in - was this addressed?

IndyJones72

IndyJones72 commented on Mar 6, 2017

@IndyJones72

@cfjedimaster - Yes it sure was. We were able to get the basic profile information needed, but I believe there's some additional information brought back which could be helpful as well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @imhoffd@cfjedimaster@sagivf@swapnilagarwwal@jaspervanveghel

        Issue actions

          Social Login not collecting user info · Issue #20 · ionic-team/legacy-ionic-cloud