Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin no longer auto-completes @Route options only (other annotations work) #205

Closed
weaverryan opened this issue Jul 19, 2020 · 3 comments

Comments

@weaverryan
Copy link
Sponsor

Hi!

I just noticed - along with another user https://symfonycasts.com/screencast/phpstorm/annotations#comment-4996614345 - that the auto-completion for options to @Route() no longer seem to work. All other annotations work fine - I tried @ORM\Column, and @Gedmo\Slug).

Missing @route annotations (the auto-complete you see is for custom "Live Templates"):

php-annotations

Functional other annotations:

Screen Shot 2020-07-19 at 10 16 45 AM

Love the plugin - just wanted to report this!

Plugin version: 7.1.2 (same problem in 7.1.1.)
PhpStorm version: 2020.1.3 (same problem in 2020.1.2)

Thanks!

@micotodev
Copy link

Not just limited to @route, also happening with other annotations like @Security/@ParamConverter.

I created an issue on the symfony plugin rather than here. Will close that Haehnchen/idea-php-symfony2-plugin#1512

@Haehnchen
Copy link
Owner

Via #182 i dropped the private property visibility. Which is the case on the classes.
Based on the doctrine-annotations the properties are public: https://www.doctrine-project.org/projects/doctrine-annotations/en/latest/custom.html#attribute-types

By looking at some Symfony annotation classes i guess instead to implement this back, the better hit rate would be using the set* methods in addition.

i am open for any better idea or suggestions.

Haehnchen added a commit that referenced this issue Jul 25, 2020
Haehnchen added a commit that referenced this issue Jul 25, 2020
support private properties again as is commonly used for navigation and documentation purpose #205
@Haehnchen
Copy link
Owner

its working in latest update again. i just reverted the removal of ignoring private properties, after investigating several project and libs usages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants