Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add symfony 5 compatibility #252

Merged
merged 3 commits into from Dec 30, 2019
Merged

add symfony 5 compatibility #252

merged 3 commits into from Dec 30, 2019

Conversation

zairigimad
Copy link
Contributor

@zairigimad zairigimad commented Oct 30, 2019

#hackdayParis
this PR depends on KnpLabs/snappy#376

@elkuku elkuku mentioned this pull request Dec 2, 2019
@garak
Copy link
Contributor

garak commented Dec 2, 2019

Lib was merged today

@wumke
Copy link

wumke commented Dec 13, 2019

Is the failing travis build the only issue to keep this PR from being merged?

Build fails for Symfony5 on php7.3 ...
Should php version requirement be changed to ^7.2.5 to fix it?

@garak
Copy link
Contributor

garak commented Dec 13, 2019

I think that travis configuration should be updated, since Symfony 5 is stable

@IonBazan
Copy link

@zairigimad @weaverryan I't enough to simply rerun the tests to pass, since lib dependencies have been adjusted. We could also test against PHP 7.4 now.

@elkuku
Copy link

elkuku commented Dec 26, 2019

ping....

@nawatend
Copy link

I dont know why im getting this error on install KnpSnappyBundle

Problem 1
- Installation request for knplabs/knp-snappy-bundle ^1.6 -> satisfiable by knplabs/knp-snappy-bundle[v1.6.0].
- knplabs/knp-snappy-bundle v1.6.0 requires symfony/framework-bundle ~2.7|~3.0|^4.0 -> no matching package found.

@fhuszti
Copy link

fhuszti commented Dec 30, 2019

@nawatend KnpSnappyBundle is not yet compatible with Symfony 5, apparently the tests just need to be reran so this pull request can be merged. I don't know who can do it though

@weaverryan weaverryan merged commit 7c5fa65 into KnpLabs:master Dec 30, 2019
@weaverryan
Copy link
Contributor

Sorry for the delay! Thank you @zairigimad! I'm going to check the test suite and see if we need any other updates before making a tag.

@Tofandel
Copy link

Hmmm.. Still not working with symfony 5

- Conclusion: don't install symfony/symfony v5.0.0-BETA2 (conflict analysis result)
- knplabs/knp-snappy-bundle v1.8.0 requires symfony/framework-bundle ^4.4|^5.1 -> satisfiable by symfony/symfony[v5.1.0-BETA1, ..., 5.x-dev], symfony/framework-bundle[v4.4.0-BETA1, ..., 4.4.x-dev, v5.1.0-BETA1, ..., 5.x-dev].
Only one of these can be installed: symfony/framework-bundle[v2.1.0, ..., 2.8.x-dev, v3.0.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev, v5.0.0-BETA1, ..., 5.x-dev], symfony/symfony[v5.0.0-BETA1, ..., 5.x-dev]. symfony/symfony replaces symfony/framework-bundle and thus cannot coexist with it.

@alexpozzi
Copy link
Member

It seems you are trying to install Snappy bundle v1.8.0 which is only compatible with Symfony >= v5.1 on a project with Symfony 5.0.
Have you tried installing Snappy bundle v1.7.x or to upgrade to Symfony 5.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants