use namespaced twig classes #127

ghost · 2019-12-18T14:30:40Z

made a mistake in the previous pr, this should be okay now.

this fixes #125, fixes #122 and makes the bundle work for twig 3.x.

see https://symfony.com/blog/preparing-your-applications-for-twig-3

mikeploeger · 2019-12-30T13:13:52Z

Please merge this commit @weaverryan to make it compatible with twig 3 & sf 5. Thank you!

mikeploeger · 2019-12-30T13:36:32Z

There seems to be a problem with this commit?

I added this into my composer.json:

     "require": {
         "knplabs/knp-time-bundle": "dev-master",
         ...
 },
     "repositories": [
         {
             "type": "vcs",
             "url": "https://github.com/zaggi-iwnl/KnpTimeBundle"
         }
     ],

Installation:

 % composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)         
Restricting packages listed in "symfony/symfony" to "5.0.*"
Package operations: 2 installs, 0 updates, 0 removals
   - Installing symfony/templating (v5.0.2): Loading from cache
   - Installing knplabs/knp-time-bundle (dev-master 714b0ec): Downloading (100%) Writing lock file
 Generating autoload files
ocramius/package-versions: Generating version class...
ocramius/package-versions: ...done generating version class
Symfony operations: 1 recipe (b25a807eab05b2a0b28d8ec443bd71ab)
   - Configuring knplabs/knp-time-bundle (>=dev-master): From auto-generated recipe
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 255
!!  
!!   // Clearing the cache for the dev environment with debug                       
!!   // true                                                                        
!!  
!!  14:30:05 CRITICAL  [php] Uncaught Error: Argument 1 passed to Knp\Bundle\TimeBundle\DateTimeFormatter::__construct() must be an instance of Symfony\Component\Translation\TranslatorInterface, instance of Symfony\Component\Translation\DataCollectorTranslator given, called in /Users/USERNAME/Sites/apps/PROJECT/var/cache/dev/ContainerSKffxCI/App_KernelDevDebugContainer.php on line 1775 ["exception" => TypeError { …}]
!!  
!!  In DateTimeFormatter.php line 17:
!!                                                                                 
!!    Argument 1 passed to Knp\Bundle\TimeBundle\DateTimeFormatter::__construct()  
!!     must be an instance of Symfony\Component\Translation\TranslatorInterface,   
!!    instance of Symfony\Component\Translation\DataCollectorTranslator given, ca  
!!    lled in /Users/USERNAME/Sites/apps/PROJECT/var/cache/dev/  
!!    ContainerSKffxCI/App_KernelDevDebugContainer.php on line 1775                
!!                                                                                 
!!  
!!  cache:clear [--no-warmup] [--no-optional-warmers] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command>
!!  
!!  
Script @auto-scripts was called via post-update-cmd

I have the latest Twig3 & SF5.0.2 installed.

mikeploeger · 2019-12-30T14:04:11Z

I have found a working solution, changes on DateTimeFormatter.php:

Line 5 old:
use Symfony\Component\Translation\TranslatorInterface;

Line 5 new:
use Symfony\Component\Translation\DataCollectorTranslator;

Line 17 old:
public function __construct(TranslatorInterface $translator)

Line 17 new:
public function __construct(DataCollectorTranslator $translator)

I don't get any errors now and the translation process is working fine.

weaverryan · 2019-12-30T14:56:09Z

Thank you @zaggi-iwnl!

use namespaced Twig classes

734e7c2

use namespaced twig classes

714b0ec

weaverryan merged commit ab88c33 into KnpLabs:master Dec 30, 2019

weaverryan mentioned this pull request Dec 30, 2019

bumping php & symfony version dependencies and making code updates #129

Merged

jrushlow added the Feature New Feature label Jul 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use namespaced twig classes #127

use namespaced twig classes #127

ghost commented Dec 18, 2019

mikeploeger commented Dec 30, 2019 •

edited

mikeploeger commented Dec 30, 2019 •

edited

mikeploeger commented Dec 30, 2019 •

edited

weaverryan commented Dec 30, 2019

use namespaced twig classes #127

use namespaced twig classes #127

Conversation

ghost commented Dec 18, 2019

mikeploeger commented Dec 30, 2019 • edited

mikeploeger commented Dec 30, 2019 • edited

mikeploeger commented Dec 30, 2019 • edited

weaverryan commented Dec 30, 2019

mikeploeger commented Dec 30, 2019 •

edited

mikeploeger commented Dec 30, 2019 •

edited

mikeploeger commented Dec 30, 2019 •

edited