No longer need to kill Chrome to run #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
..only tested on Mac. |
|
Sweet! I will take it for a spin on Windows! |
|
I merged this in, added support for windows to browser platform. Ran into an issue with getting temporary chrome user data dir to work with windows. It worked fine if I ran the command from powershell or CMD. Had errors when I ran it from spawn. This exact error. http://stackoverflow.com/questions/13211706/node-js-windows-7-spawn-chrome-cant-set-user-data-dir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions to run browser platform started with: "kill chrome". With this patch, you will use a temporary chrome user data dir (profile), which will allow you to create a second chrome process with the appropriate flags applied.