Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear semantics of PropertyMetadata::readableLink / writableLink #479

Closed
teohhanhui opened this issue Mar 21, 2016 · 3 comments
Closed

Unclear semantics of PropertyMetadata::readableLink / writableLink #479

teohhanhui opened this issue Mar 21, 2016 · 3 comments

Comments

@teohhanhui
Copy link
Contributor

Currently, readableLink actually means "return embedded representation" and writableLink means "allow writing embedded properties".

There's a mismatch between the naming and the actual semantics.

Perhaps we can change it to something like: readDereferenceable / writeDereferenceable (or readDereferenced / writeDereferenced, whichever is more correct... I'm still trying to figure this out.)
@teohhanhui
Copy link
Contributor Author

Also, these properties should be set to false (or perhaps null would be more appropriate to represent undefined semantics) when the property is not a link (relation).

@dunglas
Copy link
Member

dunglas commented Jul 25, 2016

Refactored.

@dunglas dunglas closed this as completed Jul 25, 2016
@teohhanhui
Copy link
Contributor Author

Just looked at the latest code. I don't think this has been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dunglas @teohhanhui