Checking the output option when calculating property metadata #3696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Reproducer with instructions here: https://github.com/SymfonyCasts/api-platform/tree/embedded-output-iri-embedded-bug
It's super tricky and subtle. The tl;dr is that when the
readableLink
ofPropertyMetadata
is calculated for an embedded property, it uses the serializer groups from the target resource class when it should use theoutput=
class (because that is what will actually be serialized).I didn't include a test (yet) - I'd like some validation that this it the correct place/idea for this.
Thanks!