New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore @lemire's rolling hash function as an alternative for Counttable #1616
Comments
Once #1511 is merged this is going to be easy :) As a first step I would take the code from lemire/rollinghashcpp, put what we need in |
Note that the version above only supports 19 bit hashes. Something like https://github.com/bcgsc/ntHash is more universal, however, it's under GPLv3 |
19 is the default, not the sole setting. 19 is an odd default, I'll grant you that. |
Probably I was confused by the following code:
|
@asl Right. One of our templates has weird limitations, but that's not the one you are thinking about using, I believe. |
@mohamadi has the fast rolling hash implementation ntHash https://github.com/bcgsc/ntHash |
Ah, woops. My mistake. |
Sounds like it's a moot point for khmer, since you already have #1699. If the license prevented khmer from adopting ntHash, it could be a similar impediment to other projects. Dual licensing could help its uptake. |
Awesome. Good show, Hamid. |
@asl If the license is the only thing holding you back from using a project, it never hurts to ask the author to consider relicensing. |
On second thought, there's not much benefit to dual licensing, and it would add confusion. May as well just go MIT license only. |
I just changed the license from GPL3 to only MIT. |
Thanks, Hamid! |
Great. Thanks for the responses! |
Happy to! |
I think this is fixed by #1792! |
See https://github.com/lemire/rollinghashcpp/blob/master/example.cpp
Should be much faster than murmurhash.
The text was updated successfully, but these errors were encountered: