Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDC-1952: Add support for array parameters on the SQLFilter #2624

Closed
doctrinebot opened this issue Jul 27, 2012 · 4 comments · Fixed by #8375
Closed

DDC-1952: Add support for array parameters on the SQLFilter #2624

doctrinebot opened this issue Jul 27, 2012 · 4 comments · Fixed by #8375
Assignees
@beberlei
Labels
Improvement
Milestone
2.9.0

Comments

@doctrinebot
Copy link

Jira issue originally created by user holtkamp:

The SQLFilter currently only accepts string parameters which would result in SQL like:

"tableAlias.column = '$filterParameter'"

To filter an Entity that has a lifecycle, this can be usefull to filter Entities that are in a specific state, for example:

"tableAlias.state = 1"

To be able to apply the filter on an Entity that can be in multiple states, it is usefull to be able to assign an array of states using setParameter:

$allowedStates = array(1,2,3,4);
$filter->setParameter('allowedStatesParam', $allowedStates);
sprintf("tableAlias.state IN (%s)", implode(',', $this->getParameter('allowedStatesParam')));

to eventually result in:

"tableAlias.state IN (1,2,3,4)"

However, this is currently not supported, it seems to go wrong on the PDO::quote() of the parameter. The SQL works ok when setting it statically in the filter, not taking the parameter into account.

It would be nice to have support for arrays on the setParameter()
@doctrinebot
Copy link
Author

Comment created by petr.pavel:

I've just created a pull request that implements just that. The only difference is that you don't call implode on the parameter when using it.
#1168

The usage would be:

$allowedStates = array(1,2,3,4);
$filter->setParameter('allowedStatesParam', $allowedStates);

$quotedList = $this->getParameter('allowedStatesParam');
"tableAlias.state IN ($quotedList)"

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1168] was labeled:
#1168

@doctrinebot
Copy link
Author

Comment created by @doctrinebot:

A related Github Pull-Request [GH-1168] was closed:
#1168

mnogales added a commit to mnogales/doctrine2 that referenced this issue Dec 22, 2015
@mnogales
doctrine#2624 Add support for array parameters on SQLFilter
627c404
mnogales added a commit to mnogales/doctrine2 that referenced this issue Dec 22, 2015
@mnogales
doctrine#2624 Add support for array parameters on SQLFilter
abbae05
mnogales added a commit to mnogales/doctrine2 that referenced this issue Dec 22, 2015
@mnogales
doctrine#2624 Add support for array parameters on SQLFilter
2fd4eaa
@holtkamp holtkamp mentioned this issue Dec 28, 2015
Closed
@beberlei beberlei added this to the 2.9.0 milestone Dec 5, 2020
@beberlei beberlei mentioned this issue Dec 6, 2020
Merged
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] Rework array support to use additional function to …
9764aad 
…avoid ambiguities.
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] Fix style issues, remove traversable support due to…
7f31b03 
… hashing concerns.
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] CS fixes
756a72b
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] CS fixes
86e9272
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] CS fixes
95a5a43
beberlei added a commit to beberlei/doctrine2 that referenced this issue Dec 6, 2020
@beberlei
[doctrineGH-2624] Add documentation
7e2c8cc
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] Rework array support to use additional function to …
f422960 
…avoid ambiguities.
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] Fix style issues, remove traversable support due to…
b6c1bf6 
… hashing concerns.
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] CS fixes
56c3211
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] CS fixes
49d2a7a
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] CS fixes
37cb72f
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] Add documentation
2cf1c4d
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] Rework array support to use new getParameterList()
7cc2c49
beberlei added a commit to beberlei/doctrine2 that referenced this issue Feb 28, 2021
@beberlei
[doctrineGH-2624] Rework array support to use new getParameterList()
2fcffe4
beberlei added a commit that referenced this issue Apr 19, 2021
@beberlei @mnogales @greg0ire
Support for Array parameters in SQL filters (#8375)
ddfee26 
* #1168 Add support for array parameters on the SQLFilter

* DDC-1168 Add support for array parameters on the SQLFilter

* [GH-2624] Rework array support to use new getParameterList()

* [DDC-1952] Change at() mocking to using returnCallback()

* [DDC-1952] Make arrays of values explicit with new setParameterList

* Adjust tests to use country as list and locale as single value.

* [DDC-1952] Add tests for new exxeption conditions.

* Apply suggestions from code review

Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>

Co-authored-by: Manuel Nogales <nogales.manuel@gmail.com>
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
@beberlei
Copy link
Member

Implemented by #8375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beberlei beberlei

Labels
Improvement
Projects
None yet
Milestone
2.9.0
Development

Successfully merging a pull request may close this issue.

Support for Array parameters in SQL filters beberlei/doctrine2
2 participants
@beberlei @doctrinebot