Social Login not collecting user info #20
Comments
@sagivf -- @Devnetics is actually working on this right now. None of the current social providers are collecting additional information. This was a known limitation that we are now addressing. I'll keep this open to inform you when you can expect this functionality. |
@dwieeb - Ok so even though this was for Google, we'll at the very least hopefully have this information for Google, Facebook and Twitter? |
@IndyJones72 Yes! I changed the title so it is more fitting. |
@dwieeb I've been wondering - will the platform do some sort of unification of the same person with different social logins or will each one create a new user in the system? Not sure myself which is better, I'm guessing they could be unified based on the email. Probably best if it were configurable. |
@sagivf Unification of users is actually pretty complex. Even once you're sure they're the same person (via email, for example), merging data and avoiding data destruction is a complicated process. Not all social networks give us email addresses and most don't give enough general data to piece things together. But honestly, I don't see logins being merged. If a user shares an email address in two social networks and logs in to your app with one network then the other, they would expect to have a completely new account, not their data from the other. Best to keep them as separate accounts. That being said, data analysis on users can be done while maintaining the two separate accounts. This is something we're interested in looking at later. But, obviously there's much to do before that. |
@dwieeb I agree with all of what you say. This is defiantly not a common use case for apps and not necessary to do with authentication, but it's good to keep in mind. |
@sagivf Ah, yeah. Not a use case we'd tackle with our authentication. Devs are free to add those additional hookups themselves and then save such information in users' custom data. I would say it's not in our scope to add support for that, something which could be done with plugins such as cordova-plugin-facebook4 or libraries. |
Are there any updates to report on the approximate completion date of this yet? We would like to integrate this into our app, which we'd like to release at the end of this month. |
@jaspervanveghel This will be released by the end of next week. I'll update here when it's live. |
@Devnetics - great news. We are also looking to release at the end of the month and this will be great to have |
@Devnetics did you have any news :) we also have a release but next month and give full facebook login with complete user data will be great! |
Hey guys, we have the PR ready to go on the backend to support Oauth provider user data. We didn't want to turn on a fairly complex new feature Friday afternoon, so we're hitting the on switch Monday morning. I'll post here when it's live. We are giving you access to the basic user details (such as username, email (when available), full_name, and profile_picture), and then also recorded a Note: We are not providing access to the provider tokens, that is still under discussion. |
Can I ask why you don't want to (possibly) provide the token? |
@Devnetics - Great news, and I completely understand about throwing the switch on a Friday afternoon. Really looking forward to this on Monday. |
@Devnetics Thanks for working on this. I have recently implemented something similar for a web app and was wondering regarding keeping the user data up to date - meaning what happens if a user changes his photo / email / name etc... It's not critical for most apps, but could be in some cases. Is there any implementation of this? A few words of advice:
Let me know if you I can help in any way and thanks again :) (Perhaps I should open a new ticket for this) |
Hi @Devnetics, does the PR it's ready to update or it will take a little more to be available? |
@ArkangelB We soft launched it yesterday. The new docs and cloud client are also on their way, which will give you local access to the provider data (on log in with the cloud client), and the docs will demonstrate how to use it. If you're feeling antsy and want it right now, you can use the latest version of the cloud client github.com/driftyco/ionic-cloud, but I would recommend waiting for our next publish to npm for any production level applications. @sagivf Thanks! We already have it updating user's. Any data that is changed gets overridden, anything that did not change (say for example the new set of data that comes in doesn't have email, but the old set does have email) stays the same. Currently this happens on user login. |
@Devnetics - just a quick shoutout...this is working pretty darn well. I share a few of our fellow posters in that having the token would be useful so we could obtain the email address of the user, however...and I'm reaching here...is it possible to send an email to Facebook somehow incorporating the user's FB id? If so, maybe we don't need it and not have to worry about the token and added layers of difficulty that FB may add. Just wanted to say thank you for getting this adjusted and out there. We should be almost set to release at the end of the month with this. |
Thanks @Devnetics, great to see this coming along. |
@Devnetics please suggest when will it be available for public npm ? |
Ok am I reading the code incorrectly, or shouldn't the new social login info be available in $ionicUser.social after a successful login? |
@IndyJones72 I may be wrong here but I think this is only for Ionic2, although this feature could probably easily be back ported as it's mostly server side. |
@sagivf - oh man I feel dumb then. I had thought ionic cloud was for both platforms as I did the whole migration from web platform to ionic.cloud and everything seemed to work so that's why I had asked. I do see the "data" in my network debug feed and see everything coming back from the social service. However I can't use that data for some reason in the promise...all I get is the uuid. So I'm sure I'm doing something wrong here. How difficult is it to convert your ionic 1 to ionic 2? I know there's documentation out there so not looking for details. Just curious as to the effort involved. |
Actually you maybe right @IndyJones72, I guess your using the compiled results of typescript source... I re-wrote my app since I had a lot of business changes due anyway. My advice would be:
Good luck either way :) |
@sagivf I believe data for social authentication will be available for ionic 1.3. |
Here's how this works. The Cloud Client initiates a series of HTTP redirects through our servers and the social network. At this time we store the social data, such as name, email, and profile picture on the user. The user is returned to the Cloud Client and that data will be available under @sagivf Ionic Cloud Client doesn't rely on the Ionic Framework. You can use it in Ionic 2 and Ionic 1 apps. The integration of the client into those frameworks may differ, but our new documentation will feature both. @sagivf @IndyJones72 Perhaps it's best to wait for another npm release. I'm planning on one today or tomorrow. @sagivf That's very good advice. 👍 I agree with all of it. @agarwalswapnil Those are our current docs, which won't mention anything about this new feature. |
@dwieeb - Thanks so much for the reply and the clarification. If you have another npm scheduled today, I probably will wait for that...install it since it seems the compiled version I have is missing the social part of that new user object. Please let us know when it's out there so I can give it a whirl. Thanks! |
Full notes to all for what to expect this week:
And thank you all for the continued feedback, it's been a huge help. |
@Devnetics, no worries. Right now I'm simply taking that info after login and placing it into those areas of ionicUser so I have some consistency across my logic. However, a larger question is....while I know some things may change as stated in the guides, I am planning on releasing this app in the next week here. How ok are we with doing this? |
@Devnetics will be working with this right now, it just a npm update @ionic/cloud or i will need to make part of the migration that you send? |
Hello guys i am a roockie on ionic cloud and i would like to get a code snippet on how to get user's name and picture from facebook . Also a link to the "new" docs would be really helpfull .Thanks a lot ! |
@edjeezy have you implemented the Facebook login? Also you can get the image based on the user id. |
@sagivf can you give me a sample code |
@edjeezy Are you using Ionic2 or Ionic1? |
ionic 1 but i am going to upgrade to 2 for the production version |
So code sample For which :) ? |
v1 |
I'm using V2 - but I think this should basically work -
http://docs.ionic.io/docs/user-usage But again this is what this ticket is about and will probably change soon so keep following. |
@edjeezy - I'm using v1 and this works for my app so far. Just waiting on some sample code for implementing the new Push Notifications and Deploy/Check for Updates and I can finally package this thing up for Apple Police review. Have an anxious customer. Let me know if you have any questions. @sagivf - Good advice to @edjeezy about keeping an eye on the docs.
|
Thanks for the support @sagivf . One last question @IndyJones72 can i replace this code |
@edjeezy - I don't see why not. The only reason I do it this way is because (correct me if I'm wrong @Devnetics / @dwieeb) is $ionicUser is now "global" throughout the application. So inside of one of my controllers, I do the following (if someone has a better way please chime in):
Which will now allow you inside of your template to do something such as:
Now again, the reason for this is I have about 14 controllers in this app, but hopefully this makes sense. |
Hello @dwieeb i was working to make ir work the facebook info but i looks like the problem its not ionic cloud, i update to ionic v2 and when i make a deploy ionic run ios the app does not update at all, so i think that its why i cant see the social object. So did you have an idea why does this happens or how can i fix it? i was looking around but there is not so much information about ionic v2, do i have to make a downgrade of my ionic to fix the problema? Thanks, i'll keep looking around for an answer. |
@ArkangelB Just so you know, I've always had problems with |
There are so many variables to this - Ionic cli version, cordova version, node version, ionic version, ios-deploy, ios-sim, os version, plugins, xcode version and probably more :) |
@sagivf haha it's the first time that i have problems with ionic run ios but i know what you mean, i just make a package just to know if facebook social object its working and it works so i'm happy 👍 now i can keep working with the next stage.. |
Can i know when the 'updated' docs will be available ? |
Facebook and Google fixes are live now, the null fields should be corrected. We also pushed out a fix where in some cases Google email wasn't getting fetched properly. @edjeezy We're working as fast as we can to get the updated docs out. The wait shouldn't be too much longer. |
@Devnetics thank you for the hard work . Ionic is really a dream came thrue so keep on going . |
@edjeezy Thanks! It means a lot to us to hear that. |
@Devnetics i have a question i can have the image from facebook like this $scope.imgProfile ="http://graph.facebook.com/v2.7/{user.id}/picture" and it get the same photo quality that the picture that you bring to the object but if you ask for this one $scope.imgProfile ="http://graph.facebook.com/v2.7/{user.id}/picture?type=large" it gets a much better quality, so my question is, it exist a way that we can ask for a better photo quality? |
@ArkangelB I see what you mean. I'll look into it. The base url we provide from facebook doesn't give you that capability at the moment. |
@Devnetics ok this still works pretty nice! Thanks for everything! |
Hey guys, we are going to ahead and close this issue. We are still making small tweaks/updates, nothing breaking. We have taken into account all of the feedback and will be iterating on this feature further after release of the new docs. Please report any actual errors in a new issue. |
Just checking in - was this addressed? |
@cfjedimaster - Yes it sure was. We were able to get the basic profile information needed, but I believe there's some additional information brought back which could be helpful as well now. |
Most auth systems collect the social providers user data (name, email at times, etc...).
At least for google it doesn't seem to do so.
The text was updated successfully, but these errors were encountered: