Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Policy and Honor DNT Headers (fixes #94 & #276) #282

Merged
merged 10 commits into from Jan 29, 2015
Merged

Conversation

lewisgoddard
Copy link
Member

@lewisgoddard lewisgoddard changed the title Add Privacy Policy and Honor DNT Headers Add Privacy Policy and Honor DNT Headers (fixes #94 & #276) Jan 29, 2015
@lewisgoddard
Copy link
Member Author

I suppose we should have a link from every page, international standard and all that.

@martpie
Copy link
Collaborator

martpie commented Jan 29, 2015

You just forgot a link to the new Privacy Policy page ;) (in footer I guess). Otherwise it's great.

@davidak
Copy link

davidak commented Jan 29, 2015

DNT works, thank you :)

@cassidyjames
Copy link
Contributor

@lewisgoddard some of the wording is messy. I'll propose changes here as I see 'em.

<div class="row" style="max-width:1000px;">
<h1>Privacy Policy</h1>
<h2>Do Not Track</h2>
<p>This site honors the do-not-track setting found in most modern browsers, and disables Google Universal Analytics when it is present. Unfortunately, we cannot remove other tracking methods without severely impacting the use of the site. Should you wish to do so, reference the section on disabling cookies.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site honors the do-not-track setting found in most modern browsers, and disables Google Universal Analytics when it is present. Unfortunately, we cannot remove other tracking methods without severely impacting the use of the site. Should you wish to do so, reference the section on disabling cookies.

Change to:

This site honors the do-not-track setting found in most modern browsers and disables Google Analytics when it is present. We cannot automatically remove other tracking methods without severely impacting the use of the site. Should you wish to manually manage these tracking methods, reference the section on disabling cookies.

@cassidyjames
Copy link
Contributor

Okay, the comments look weird on the Pull Request overview, but make more sense if you view them inline in the code changes.

@danirabbit
Copy link
Member

Can we get line breaks after each sub section header in "Cookies"?

(After Cassidy's inline link changes) For external links at the end of a paragraph I think it makes sense to use the "read-more" class.

@lewisgoddard
Copy link
Member Author

What do you mean by sub-section headers?
The product names in bold?

danirabbit added a commit that referenced this pull request Jan 29, 2015
Add Privacy Policy and Honor DNT Headers (fixes #94 & #276)
@danirabbit danirabbit merged commit 357d501 into master Jan 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Policy [$15 awarded]
6 participants