Fix menuitems ordering #2

gordienko · Aug 13, 2022 · fbea56e · fbea56e
1 parent 6f5e895
commit fbea56e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/app/controllers/menuitems_controller.rb b/app/controllers/menuitems_controller.rb
@@ -59,16 +59,7 @@ def destroy
 
   def move
     @menuitem = Menuitem.find(params[:id])
-    if params[:ancestry] == 'undefined'
-      @menuitem.update_columns(ancestry: nil)
-    else
-      @menuitem.update_columns(ancestry: params[:ancestry])
-    end
-
-    @menuitem.siblings.order(:position).each.with_index(1) do |item, index|
-      item.update_column(:position, index)
-    end
-
+    @menuitem.update(parent_id: params[:ancestry] == 'undefined' ? nil : params[:ancestry])
     @menuitem.insert_at(params[:position].to_i)
     head :ok
   end

diff --git a/db/seeds.rb b/db/seeds.rb
@@ -1 +1 @@
-1000.times { |n| Menuitem.create!(name: "Menu title number #{n}") }
+20.times { |n| Menuitem.create!(name: "Menu title number #{n}") }