Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug where apply tag was used but allowed non-supported Twig versions #1249

Merged
merged 1 commit into from Dec 10, 2019

Conversation

weaverryan
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR not needed!

Hi!

In #1176, we started using the apply tag. But that was not available until Twig 1.40 (reference https://twig.symfony.com/doc/1.x/tags/apply.html) and Twig 2.9 (reference https://twig.symfony.com/doc/2.x/tags/apply.html).

The Twig range needs to be updated to reflect this.

Thanks!

@michellesanver
Copy link
Contributor

Awesome! Thanks Ryan! :)

@michellesanver michellesanver merged commit c936c27 into liip:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants