Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renaming nexy_slack.client service to Nexy\Slack\Client #31

Merged
merged 18 commits into from Aug 12, 2019
Merged

renaming nexy_slack.client service to Nexy\Slack\Client #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7c2ebbf
renaming nexy_slack.client service to Nexy\Slack\Client
nicklasaloq Oct 24, 2018
929f663
adding service alias and deprecation message
nicklasaloq Oct 24, 2018
29ce0bb
removed service alias arguments
nicklasaloq Oct 24, 2018
8899217
added %service_id% to deprecation message
nicklasaloq Oct 24, 2018
13c2542
added %service_id% to deprecation message
nicklasaloq Oct 24, 2018
74d1981
added %service_id% to deprecation message
nicklasaloq Oct 24, 2018
e59588d
created alias
nicklasaloq Oct 25, 2018
91ca1ae
turned back to old setup
nicklasaloq Oct 25, 2018
dadcfa0
Merge branch 'master' into master
SeaquestNet Aug 6, 2019
1a1e7fe
old service id is now alias of new service id Nexy\Slack\Client
nicklasaloq Aug 7, 2019
28321d8
add class to service
nicklasaloq Aug 7, 2019
dd2c526
remove class from service
nicklasaloq Aug 10, 2019
0b80118
remove class from test
nicklasaloq Aug 10, 2019
5ccb8c4
add test for alias
nicklasaloq Aug 10, 2019
d0b23e3
add test for alias
nicklasaloq Aug 10, 2019
efa2cff
Use ::class notation
soullivaneuh Aug 12, 2019
e157d8b
Restore space
soullivaneuh Aug 12, 2019
dd89d3f
Changelog note
soullivaneuh Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Add client service autowiring

## [2.1.0]
### Added
Expand Down
4 changes: 3 additions & 1 deletion src/Resources/config/client.xml
View file
Open in desktop
Expand Up @@ -5,10 +5,12 @@
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">

<services>
<service id="nexy_slack.client" class="Nexy\Slack\Client" public="true">
<service id="Nexy\Slack\Client" public="true">
<argument>%nexy_slack.endpoint%</argument>
<argument>%nexy_slack.config%</argument>
<argument type="service" id="nexy_slack.http.client" />
</service>

<service id="nexy_slack.client" alias="Nexy\Slack\Client"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really should have been done in the other direction: we typically make the actual service id the snake-case version and then create an alias for the autowiring.

</services>
</container>
9 changes: 5 additions & 4 deletions tests/DependencyInjection/NexySlackExtensionTest.php
View file
Open in desktop
Expand Up @@ -47,12 +47,13 @@ public function testLoadWithMinimalConfiguration(): void
$this->assertContainerBuilderHasParameter('nexy_slack.endpoint', $endpoint);
$this->assertContainerBuilderHasParameter('nexy_slack.config', $slackConfig);

$this->assertContainerBuilderHasService('nexy_slack.client', Client::class);
$this->assertContainerBuilderHasService(Client::class);

$this->assertContainerBuilderHasServiceDefinitionWithArgument('nexy_slack.client', 0, '%nexy_slack.endpoint%');
$this->assertContainerBuilderHasServiceDefinitionWithArgument('nexy_slack.client', 1, '%nexy_slack.config%');
$this->assertContainerBuilderHasServiceDefinitionWithArgument('nexy_slack.client', 2, new Reference('nexy_slack.http.client'));
$this->assertContainerBuilderHasServiceDefinitionWithArgument(Client::class, 0, '%nexy_slack.endpoint%');
$this->assertContainerBuilderHasServiceDefinitionWithArgument(Client::class, 1, '%nexy_slack.config%');
$this->assertContainerBuilderHasServiceDefinitionWithArgument(Client::class, 2, new Reference('nexy_slack.http.client'));

$this->assertContainerBuilderHasAlias('nexy_slack.client', Client::class);
$this->assertContainerBuilderHasAlias('nexy_slack.http.client', 'httplug.client');
}

Expand Down