Symfony 5 and nexylan/slack 3.0 support #34
Conversation
|
Well, this ended up becoming more involved than I expected. Basically, to get around dealing with differing signatures in different versions of
Only the first one in that list will affect bundle users, but considering that version is hours away from EOL at this point I'd say not an issue. |
There was a problem hiding this comment.
Thanks for the work, I appreciate ! 👍
Only the first one in that list will affect bundle users, but considering that version is hours away from EOL at this point I'd say not an issue.
Not our problem, we can easily upgrade your constraints on a new minor according to semver.
And you are right, EOL means "do not use it anymore", after all! 😉
Travis does not seem happy with your new Symfony v5 environment, would you mind to take a look?
It looks like this is blocked by php-http/HttplugBundle#360, once HttplugBundle updated and has a new release in theory this should be OK. |
mbabker
changed the title
|
HttplugBundle finally had a release yesterday. So, bumping this bundle's minimum version of that up to the new version got most things passing. But, the Symfony 5 build still couldn't resolve a full set of dependencies because the |
| @@ -38,6 +38,8 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->addDefaultsIfNotSet() | |||
| ->children() | |||
| ->scalarNode('client')->defaultValue('httplug.client')->end() | |||
| ->scalarNode('request_factory')->defaultValue('nexy_slack.request_factory.default')->end() | |||
| ->scalarNode('stream_factory')->defaultValue('nexy_slack.stream_factory.default')->end() | |||
There was a problem hiding this comment.
Same logic as with the HTTP client class, allow a bundle user to replace the request and stream factories with their own implementation.
| </service> | ||
|
|
||
| <service id="nexy_slack.client" alias="Nexy\Slack\Client"/> | ||
|
|
||
| <service id="nexy_slack.request_factory.default" class="Psr\Http\Message\RequestFactoryInterface"> |
There was a problem hiding this comment.
HttplugBundle doesn't provide services directly creating the PSR-17 factories, so the services here are the defaults used to discover compatible factories through the Httplug discovery system.
|
Thank for your work and your time! 👍 |
Also adds PHP 7.3 to the CI configuration