Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Stimulus 3 Support #170

Merged
merged 23 commits into from May 10, 2022
Merged

Native Stimulus 3 Support #170

merged 23 commits into from May 10, 2022

Conversation

adrienpoly
Copy link
Contributor

mostly replace stimulus imports by @hotwired/stimulus

this version can be tested by installing v0.50.0-0 beta version

yarn add stimulus-use@beta

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this going - an annoying detail - we're doing the same over in the symfony packages :)

package.json Outdated Show resolved Hide resolved
@weaverryan
Copy link
Contributor

Hey @adrienpoly!

Were you planning to make a release using this sometime soon? We're (on Symfony UX) sort of waiting for the ecosystem to start supporting v3 before we jump to it. That's already happening (e.g. stimulus-autocomplete just released v3 support), so things are in a weird "in between" spot now. If you released v3 support, I would push to get our support released - but I may push for it anyways soon either way.

Thanks!

@fedegl
Copy link

fedegl commented Dec 17, 2021

Hello @adrienpoly. Thanks for the awesome library!

As others have commented, I am too waiting on the new release to be able to upgrade to Stimulus 3.0. I understand that it's on you own time and you might be busy. But if you could just give us a bit of an expectation on when are you planning on releasing this update, it would help to make a decision on what to do with regards to this library.

Thanks!

@abunch
Copy link

abunch commented Mar 26, 2022

Hi @adrienpoly

Any update on when this will get merged in?

@janklan
Copy link

janklan commented Apr 26, 2022

I'm not sure where is the best place to ask, so I'll ask here: Is this repo/project dead?

@marcoroth
Copy link
Member

Hey @janklan, it's definitely not dead. We are looking to get this merged in asap, there were just a lot of moving parts in the Hotwire space.

@janklan
Copy link

janklan commented Apr 26, 2022

Hey @janklan, it's definitely not dead. We are looking to get this merged in asap, there were just a lot of moving parts in the Hotwire space.

Phew, that's a relief. I'm looking at ditching AlpineJS for Stimulus in my Symfony application, and this package seems to be a make-or-brake part in doing so. Last commit 7 months ago is usually a sign of bad things on the horizon.

Is there a timeline?

I know it's open source, people invest their time etc etc., so I'm not trying to be pushy in any way, I just need to make an executive decision to either dive in the beta, or hold back.

@marcoroth
Copy link
Member

marcoroth commented Apr 27, 2022

Is there a timeline?

There is no official timeline.

But I'm planning to work on getting the library updated in this coming week, there are a few chores which are overdue.

@janklan
Copy link

janklan commented Apr 27, 2022

Cool, thanks for the update!

@weaverryan
Copy link
Contributor

@marcoroth If you're able to list any of those chores... and the rest of us can help, seriously let us know :). Thanks for your efforts - looking forward to the non-beta 0.50 release!

@marcoroth marcoroth changed the title Stimulus 3 Native Stimulus 3 Support May 9, 2022
* Upgrade Playground

Use Vite

Upgrade Tailwind

Extract Stimulus `application.js`

Expose Stimulus Application on `window`

Removed some dependencies from main `package.json`

* explictly set vite server port

* also set vite server host explicitly

* Upgrade Cypress

* prepend vite commands with `yarn`

* install playground deps
@marcoroth
Copy link
Member

Thanks for your offer @weaverryan. I think at this point it doesn't really make sense to split up the work. But I really appreciate it!

We are super close to release the final version!

@marcoroth marcoroth merged commit 3cd45d2 into main May 10, 2022
@marcoroth
Copy link
Member

Good news! We just released 0.50.0 which ships native support for Stimulus 3, thanks your for patience!

You should also be able to remove the stimulus npm package from your package.json, given no other package depends on it.

Please let us know if you see anything unexpected, thank you!

@marcoroth marcoroth deleted the stimulus-3 branch May 10, 2022 21:57
@janklan
Copy link

janklan commented May 10, 2022

The best news to read the first thing in the morning. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants