Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice on Symfony 4.2 #394

Closed
gabiudrescu opened this issue Mar 11, 2019 · 41 comments
Closed

Deprecation notice on Symfony 4.2 #394

gabiudrescu opened this issue Mar 11, 2019 · 41 comments

Comments

@gabiudrescu
Copy link

I've added this bundle as a dependency of a Symfony 4.2 project and started to get deprecation notices like the one below:

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0.

stack:

[▼
  "exception" => SilencedErrorContext {#613 ▼
    +count: 13
    -severity: E_USER_DEPRECATED
    trace: {▼
      /var/www/site/vendor/symfony/config/Definition/Builder/TreeBuilder.php:30 {▶}
      /var/www/site/vendor/stof/doctrine-extensions-bundle/DependencyInjection/Configuration.php:17 {▶}
    }
  }
]
@gabiudrescu
Copy link
Author

I can see that the problem was solved in master, but without a tag, it forces users to use dev@master.

is there any chance to get this tagged?

@JustBlackBird
Copy link

@stof Could you please tag a new version with the fix?

@n-osennij
Copy link

No tag?

@mikeploeger
Copy link

@stof Could you please tag a new version with the fix?

@mysyfy
Copy link

mysyfy commented Apr 5, 2019

+1 for tag please!

@teian
Copy link

teian commented Apr 12, 2019

a Tag would be very much appreciated

@BoShurik
Copy link

Just a friendly reminder for @stof to tag a release :-)

@Ciloe
Copy link

Ciloe commented Apr 18, 2019

I @stof can you tag a new minor version with the fix please ? 🎁 👍 🥇 🙏

@n-osennij
Copy link

n-osennij commented Apr 18, 2019

It is so sad that me have to wait so long. This is very bad... 😒

@mvannes
Copy link

mvannes commented May 1, 2019

A tag would be lovely!

@tarlepp
Copy link
Contributor

tarlepp commented May 1, 2019

@stof what is the hold up for new release? Could we help you with this somehow?

@Kevin-Adrea
Copy link

Tag pliz @stof !

@GDIBass
Copy link

GDIBass commented May 15, 2019

Another request for a new tag! Please, @stof ?

@apIncubout
Copy link

Please @stof a new tag will be nice?

@miisieq
Copy link

miisieq commented May 15, 2019

@stof, can we help you somehow to maintain this project?

@gsirin
Copy link

gsirin commented May 22, 2019

@stof pleaaaaaaseeeeee...... tag it!

@javiereguiluz
Copy link
Contributor

I know it's been a long wait, but please 🙏 try to understand that sometimes maintainers don't have time for their open source projects for some reasons.

I'm sure @stof will tag a new version when he's ready again to maintain this bundle. Please, have some patience. Moreover, not having a new version only means that you'll get some deprecation messages. It's not such a big deal. Thank you!

@JustBlackBird
Copy link

@javiereguiluz can I somehow help to maintain the project?

@javiereguiluz
Copy link
Contributor

@JustBlackBird I don't know, but thanks for trying to help! @stof is the maintainer of this bundle, so he will decide if he needs a helping hand.

@mmarton
Copy link

mmarton commented Jun 5, 2019

I know it's been a long wait, but please pray try to understand that sometimes maintainers don't have time for their open source projects for some reasons.

I'm sure @stof will tag a new version when he's ready again to maintain this bundle. Please, have some patience. Moreover, not having a new version only means that you'll get some deprecation messages. It's not such a big deal. Thank you!

with all due respect, tagging a new release or at least answering to 3 month old issues in a widely used bundle isn't that hard

@tacman
Copy link

tacman commented Jun 10, 2019

The issue is that if developers get in the habit of ignoring messages (like the deprecation messages here) then it's easy to miss something that's more important. I think that 100% of my deprecation errors on a new Symfony 4.3 project are from this bundle, so was hoping to get rid of them (without changing stability and using dev-master). So just adding my voice to the chorus respectfully requesting a new version tag.

@nicodmf
Copy link

nicodmf commented Jun 12, 2019

@stof ?

@picks44
Copy link

picks44 commented Jun 13, 2019

Same here, please find a way to fix this!

@apphancer
Copy link

@stof please tag

@n-osennij
Copy link

repo is dead...

@christophermichaelthomasmillar

It appears @stof is ignoring this repo. There are many forks of this repo already is there a supported one?

@geoff-maddock
Copy link

Interested in this tag or maintained fork.

@mpdude
Copy link

mpdude commented Aug 2, 2019

By the way, what’s the best pattern to handle this change while maintaining both Symfony <4.3 and ^4.3 compatibility?

@antishov
Copy link

antishov commented Aug 7, 2019

Hi, after waiting for a while, I made my own fork antishov/doctrine-extensions-bundle, tested master branch and released it as v1.4.0.
I really like this bundle and think that it's very helpful, so I plan to maintain it. Next steps are:

  • Fix issues from this repo
  • Remove support of old PHP versions: 5.3, 5.4, 5.5
  • Improve tests coverage
  • Prepare it for Symfony 4.4
  • Add support of PHP 7.3 and 7.4

@mmarton
Copy link

mmarton commented Aug 7, 2019

@antishov respect for your decision. Let me know if you need any help.

@tacman
Copy link

tacman commented Aug 8, 2019

Remove support of old PHP versions: 5.3, 5.4, 5.5

IMO, there's no reason to support PHP5 at all. I would propose only supporting php7.1+.

How about dropping support altogether for Symfony 2 and 3? That is, only support Symfony 4.3 and 4.4. Anyone who needs this bundle for those versions can continue to use the original repo, and they won't switch to this fork

The master branch of the bundle is in sync with Symfony master branch which contains a BC break. If you are using a 2.0.x version of Symfony, you need to use the 1.0.x branch of the bundle.

This line in the documentation has always made me think that this bundle was a relic. Thank for for modernizing it!

@antishov
Copy link

@tacman great ideas for a new major version, thank you!

@ghost
Copy link

ghost commented Sep 18, 2019

FYI : symfony/symfony-docs#12332 (comment)

@gsirin
Copy link

gsirin commented Sep 26, 2019

at least he is alive :)
symfony/demo#1029 (comment)

@JohJohan
Copy link

JohJohan commented Oct 7, 2019

+1

1 similar comment
@cobyl
Copy link

cobyl commented Nov 1, 2019

+1

@Cocray
Copy link

Cocray commented Jan 30, 2020

Symfony doc (https://symfony.com/doc/current/doctrine.html#doctrine-extensions-timestampable-translatable-etc) now recommend to use https://github.com/antishov/StofDoctrineExtensionsBundle.

So I suggest to migrate to @antishov bundle instead to continue to use this dead bundle. Thanks @antishov :)

@ZaneCEO
Copy link

ZaneCEO commented Jan 30, 2020

Thanks @Cocray ! I switched to the new repo and I get no more Deprecations!

For those looking to do the same: this removes the old bundle and installs the new one:

composer remove stof/doctrine-extensions-bundle
composer require antishov/doctrine-extensions-bundle

@picks44
Copy link

picks44 commented Jan 30, 2020

Awesome, thanks @Cocray !

@JohJohan
Copy link

JohJohan commented Feb 4, 2020

thanks @ZaneCEO i used:

composer remove stof/doctrine-extensions-bundle --no-scripts
composer require antishov/doctrine-extensions-bundle

Otherwise i would get cache clear errors

@stof
Copy link
Owner

stof commented Mar 30, 2020

1.4.0 is now released.

@stof stof closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests