Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation for symfony/config 4.2+ #324

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Dec 5, 2018

Fix deprecation for symfony/config 4.2

Fixed the same way as in doctrine/DoctrineBundle#853

@pau1z
Copy link

pau1z commented Dec 11, 2018

Can you please merge this? :)

@weaverryan
Copy link
Member

Thank you @Jibbarth!

@weaverryan weaverryan merged commit 560d03c into symfony:master Dec 13, 2018
weaverryan added a commit that referenced this pull request Dec 13, 2018
This PR was merged into the 1.0-dev branch.

Discussion
----------

Fix deprecation for symfony/config 4.2+

Fix deprecation for symfony/config 4.2

Fixed the same way as in doctrine/DoctrineBundle#853

Commits
-------

560d03c Fix deprecation for symfony/config 4.2+
@Jibbarth Jibbarth deleted the fix/tree-builder-without-root-node-deprecation branch December 13, 2018 08:00
bits4breakfast added a commit to bits4breakfast/aws-sdk-php-symfony that referenced this pull request Jan 5, 2019
bits4breakfast added a commit to bits4breakfast/StofDoctrineExtensionsBundle that referenced this pull request Jan 6, 2019
kblais pushed a commit to kblais/json-request-bundle that referenced this pull request Feb 22, 2019
lchrusciel added a commit to Sylius/PluginSkeleton that referenced this pull request Apr 18, 2019
This PR was merged into the 1.3 branch.

Discussion
----------

Fix deprecation for symfony/config 4.2

Fixed the same way as in symfony/maker-bundle#324

Commits
-------

bec5182 Fix deprecation for symfony/config 4.2+
Doqnach added a commit to Doqnach/woohoolabs-yin-bundle that referenced this pull request Dec 17, 2019
qpautrat pushed a commit to qpautrat/woohoolabs-yin-bundle that referenced this pull request Dec 17, 2019
* Fixed symfony 4.2 deprecation

The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "qp_woohoolabs_yin" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead

* [patch-1] Use BC layer for deprecation in symfony/config

see symfony/maker-bundle#324 and doctrine/DoctrineBundle#853

Remove the BC layer when bump to next major version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants