Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using the security checker in all environments #402

Merged
1 commit merged into from Apr 23, 2018

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Apr 23, 2018

Q A
License MIT

We received an issue report in the Docs: symfony/symfony-docs#9612 of a user that installed the security checker but can't use it in their CI environment (APP_ENV=CI).

Is there any strong reason to only allow using this in the dev environment? I'd say you can/must use this critically important command even in prod env.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit fee0b8c into symfony:master Apr 23, 2018
ghost pushed a commit that referenced this pull request Apr 23, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants