Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy-log-handler] remove recipe #751

Merged
1 commit merged into from Apr 7, 2020
Merged

[easy-log-handler] remove recipe #751

1 commit merged into from Apr 7, 2020

Conversation

nicolas-grekas
Copy link
Member

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

@javiereguiluz maybe you know about this?
@fabpot otherwise?
This looks scary for now :)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@javiereguiluz
Copy link
Member

Instead of removing this FIXME ... what if we:

  • Remove this recipe entirely
  • Deprecate the package

I created this package because log files were a mess for me ... but recently PhpStorm added syntax highlighting and other improvements to logs ... so I no longer need this package. What do you think?

@nicolas-grekas nicolas-grekas changed the title [easy-log-handler] remove FIXME [easy-log-handler] remove recipe Apr 6, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member Author

Works for me, recipe is now removed.

@nicolas-grekas nicolas-grekas marked this pull request as ready for review April 6, 2020 15:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

nicolas-grekas added a commit to symfony/debug-pack that referenced this pull request Apr 6, 2020
@nicolas-grekas
Copy link
Member Author

Here is the sidekick PR to merge+tag: symfony/debug-pack#11

@Nyholm
Copy link
Member

Nyholm commented Apr 6, 2020

Could you please elaborate why this is removed?

fabpot added a commit to symfony/debug-pack that referenced this pull request Apr 7, 2020
This PR was merged into the master branch.

Discussion
----------

Remove easy-log-handler

As advised in symfony/recipes#751

Commits
-------

1f79abf Remove easy-log-handler
@ghost ghost merged commit 2de05e1 into symfony:master Apr 7, 2020
@nicolas-grekas nicolas-grekas deleted the zelog branch April 7, 2020 10:09
@B-Galati
Copy link
Contributor

B-Galati commented Apr 8, 2020

@javiereguiluz could you share with us the way you're going through logs with PhpStorm? It looks very interesting :-) 🙏

@javiereguiluz
Copy link
Member

@B-Galati the best of all is that I don't do anything special :) What I tried to say in my previous comment is that in the past, PhpStorm showed logs as an endless stream of black & white text. I couldn't find anything there.

But in recent versions, logs are shown like this (by default, no plugins installed):

phpstorm-logs

For me this is more than enough. The highlighting makes everything very easy to find. I know that the Monolog handler that we removed is a bit better sometimes because it formats some information in several lines, etc. But 95% of the times, PhpStorm is enough for me. That's why I suggested removing this.

@B-Galati
Copy link
Contributor

B-Galati commented Apr 8, 2020

Thanks @javiereguiluz, super interesting 👍

(It was not working for me because I had Ideolog plugin enabled)

@B-Galati
Copy link
Contributor

B-Galati commented Apr 8, 2020

I configured Ideolog and it's also giving me something easier to read FYI:

image

@cristi-contiu
Copy link

For projects started before this release and using the EasyLogHandler from the official symfony/debug-pack, this will actually break the dev build after running composer update , as the easycorp/easy-log-handler package will be removed but not the config file added by the original recipe (which references the EasyCorp\EasyLog\EasyLogHandler service).

I am also using the latest PhpStorm 2020.1 but I have no syntax highlighting on the logs, with our without Ideolog.

@javiereguiluz
Copy link
Member

@cristi-contiu I'm using PhpStorm 2019.3 and I haven't installed any plugin related to logs. In fact, I only have 4 custom plugins, so that's why I think this must be some built-in behavior:

image

@cristi-contiu
Copy link

cristi-contiu commented Apr 26, 2020

@javiereguiluz Thank you very much for your reply! In case anyone else has the same issue, watch out for File Types associated to the .log extension. In my case, the .log files were associated with the "ANSI Aware" file type the from the "ANSI Highlighter" plugin. Removing the association from PHPStorm Settings > Editor > File Types > ANSI Aware or uninstalling the plugin did the trick.

Before (notice the .dev.log file icon vs the .env icon):
image

After:
image

@ostrolucky
Copy link

PHPStorm 2020.1, removed association of *.log for ANSI Aware plugin, still can't see behaviour you are describing

Screenshot 2020-04-26 at 15 43 10

@cristi-contiu
Copy link

@ostrolucky Do you see the color scheme on the .env file?

@ostrolucky
Copy link

@cristi-contiu WDYM? If I have some sort of syntax highlighting in .env file? No, I don't

@cristi-contiu
Copy link

@ostrolucky My bad, I thought that the .env files color scheme was the same as the .log files. It turns out the .env file color scheme was given by a PHPStorm plugin.

As a test, I disabled all downloaded plugins and still got syntax highlighting for .log files (but not in .env files). I left all bundled plugins enabled.

In my case, the .log files are identified as Text file type (using the *.log pattern), but even if I remove the association, I still get highlighting. My color scheme is Darcula (but the highlighting also work with Classic Light and other themes).

@dkarlovi
Copy link

@ostrolucky you might have Ideolog plugin installed. Interestingly, it will not detect the log format here, if I uninstall it, it starts working for me.

@ostrolucky
Copy link

Fresh PC and installation, here is how it looks first time opening these log files for me:

Screenshot 2020-06-15 at 17 13 41

Installing either of these plugins doesn't help. I really don't know how this works for everybody else out of the box :(

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants