Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Symlink and config yaml #1097

Closed
wants to merge 0 commits into from
Closed

Update Symlink and config yaml #1097

wants to merge 0 commits into from

Conversation

ychadwick
Copy link
Contributor

Q A
License MIT

ghost
ghost suggested changes Feb 16, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Feb 16, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost approved these changes Feb 16, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@nicolas-grekas
Copy link
Member

Please rebase to run checks again.

@Nyholm
Copy link
Member

Nyholm commented Aug 2, 2021

Friendly ping

@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On *nix and Mac
export SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1097
# On Windows
SET SYMFONY_ENDPOINT=https://api.github.com/repos/symfony/recipes-contrib/contents/index.json?ref=flex/pull-1097

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'networking/init-cms-bundle:^4.4'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On *nix and Mac
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

networking/init-cms-bundle

4.0 vs 4.4 
diff --git a/networking/init-cms-bundle/4.0/config/packages/networking_init_cms.yaml b/networking/init-cms-bundle/4.4/config/packages/networking_init_cms.yaml
index f081118c..8f433ac7 100644
--- a/networking/init-cms-bundle/4.0/config/packages/networking_init_cms.yaml
+++ b/networking/init-cms-bundle/4.4/config/packages/networking_init_cms.yaml
@@ -7,7 +7,6 @@ imports:
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/oneup_uploader.yaml" }
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_admin.yaml" }
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_block.yaml" }
-    - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_core.yaml" }
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_doctrine_admin.yaml" }
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_media.yaml" }
     - { resource: "@NetworkingInitCmsBundle/Resources/config/cms/sonata_notification.yaml" }

@ychadwick ychadwick closed this Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ychadwick @nicolas-grekas @Nyholm