Supporting Stimulus 3 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see how you could get fancy. Changing peer dependencies is a BC break. |
|
Yup, the “fancy” would require not listing either as a peer dependency and hoping for the best. So not really an option :) |
weaverryan
force-pushed
the
stimulus3
branch
from
47095fe
to
7091876
Compare
stof
reviewed
Sep 28, 2021
1 task
4 tasks
tgalopin
approved these changes
Nov 24, 2021
|
Thanks @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Stimulus 3. Unless we get fancy (which we could I think, but it's a bit unnatural), this will require a new major release of this library.
TODOs:
@symfony/stimulus-testingneeds to be updated to work with Stimulus 3Before a tag, we need to