Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add missing dot at the end of an exception message
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e1f978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is a BC break, because it was a common way to override the
Bad credentials
text with localized message:https://groups.google.com/forum/#!topic/symfony2/5QM_zQcEEdU
http://stackoverflow.com/questions/9201849/customize-authentication-login-symfony2-messages
http://forum.symfony-project.org/viewtopic.php?f=23&t=34997
http://stackoverflow.com/questions/8865911/recommended-way-of-translating-authentication-errors-in-symfony2
8e1f978
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raziel057 the recommended way to display translated messages to the end user as of Symfony 2.2 is not to use the exception message (which may not always be safe as it can be a message coming from a PDO exception if your query to load users is broken for instance).