Skip to content

Composer warning when installing Codeception: "Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge" #27289

New issue
New issue
Closed
Closed
Composer warning when installing Codeception: "Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge"#27289
Labels
BugPhpUnitBridgeStatus: Needs ReviewStatus: Waiting feedback
@ThomasLandauer

Description

@ThomasLandauer
ThomasLandauer
opened on May 16, 2018
Contributor

Symfony version(s) affected: 4

Description

When installing Codeception in Symfony 4 with composer require "codeception/codeception" --dev (as recommended at https://codeception.com/quickstart ), I'm getting this warning from composer:

Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge.

Plus this hint:

Instead:
1. Remove it now: composer remove --dev phpunit/phpunit
2. Use Symfony's bridge: composer require --dev phpunit

I already reported this as a possible Codeception issue, but received the answer that it's more a Symfony issue: Codeception/Codeception#4974

Activity

sinner

sinner commented on May 18, 2018

@sinner
sinner
on May 18, 2018

I have the same problem but using Behat

xabbuh
mentioned this on May 18, 2018
nicolas-grekas

nicolas-grekas commented on May 18, 2018

@nicolas-grekas
nicolas-grekas
on May 18, 2018 · edited by nicolas-grekas
Member

We could solve this by allowing codeception/behat/etc. to be added on top of the phpunit that is built by the bridge.
This could be done by adding a SYMFONY_PHPUNIT_REQUIRE env var to configure the bridge (similar to SYMFONY_PHPUNIT_REMOVE).
Might need more thought to be made to work seamlessly with recipes.

zored

zored commented on Jun 7, 2018

@zored
zored
on Jun 7, 2018

I think we have a compatability problem here now because of /bin/.phpunit/ and /vendor/ mix. Example:

$ composer create-project symfony/skeleton .
$ composer require phpunit
$ bin/phpunit
# OK
$ composer require codeception/codeception
$ bin/phpunit
# We get:
PHP Fatal error:  Declaration of Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7::addError(PHPUnit\Framework\Test $test, Throwable $t, float $time): void must be compatible with PHPUnit\Framework\TestListener::addError(PHPUnit\Framework\Test $test, Exception $e, $time) in /Users/robert.akhmerov/git/gitlab.fun.co/backend/ssss/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerForV7.php on line 27
stof

stof commented on Jun 7, 2018

@stof
stof
on Jun 7, 2018
Member

can you show the output of composer show so that we can see the versions of packages you have installed ?

xabbuh
added
Bug
PhpUnitBridge
Status: Waiting feedback
on Jun 7, 2018
carsonbot
added
Status: Needs Review
on Jun 7, 2018
tonivdv

tonivdv commented on Jun 12, 2018

@tonivdv
tonivdv
on Jun 12, 2018

I've got the exact same issue as @ThomasLandauer but with a different package. In my case I try to require https://github.com/martin-helmich/phpunit-json-assert which in their composer.json they have

"require": {
        "flow/jsonpath": "^0.3.1",
        "phpunit/phpunit": ">=6.0",
        "justinrainbow/json-schema": "^5.0",
        "php": ">=7.0"
    },

When I do composer require --dev helmich/phpunit-json-assert in my sf4 project , I get the same as @ThomasLandauer

 Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge.

  * Instead:
    1. Remove it now: composer remove --dev phpunit/phpunit
    2. Use Symfony's bridge: composer require --dev phpunit

But it's only a warning as the tests work as expected.

Cheers

0xdfgp

0xdfgp commented on Jun 21, 2018

@0xdfgp
0xdfgp
on Jun 21, 2018 · edited by 0xdfgp

can you show the output of composer show so that we can see the versions of packages you have installed ?

@stof Same problem here. This is my composer show output:

behat/gherkin                       v4.5.1             Gherkin DSL parser for PHP 5.3
codeception/codeception             2.4.2              BDD-style testing framework
codeception/phpunit-wrapper         7.1.4              PHPUnit classes used by Codeception
codeception/stub                    2.0.1              Flexible Stub wrapper for PHPUnit's Mock Builder
doctrine/annotations                v1.6.0             Docblock Annotations Parser
doctrine/cache                      v1.7.1             Caching library offering an object-oriented API for many cache backends
doctrine/collections                v1.5.0             Collections Abstraction library
doctrine/common                     v2.8.1             Common Library for Doctrine projects
doctrine/dbal                       v2.7.1             Database Abstraction Layer
doctrine/doctrine-bundle            1.9.1              Symfony DoctrineBundle
doctrine/doctrine-cache-bundle      1.3.3              Symfony Bundle for Doctrine Cache
doctrine/doctrine-migrations-bundle v1.3.1             Symfony DoctrineMigrationsBundle
doctrine/inflector                  v1.3.0             Common String Manipulations with regard to casing and singular/plural rules.
doctrine/instantiator               1.1.0              A small, lightweight utility to instantiate objects in PHP without invoking their constructors
doctrine/lexer                      v1.0.1             Base library for a lexer that can be used in Top-Down, Recursive Descent Parsers.
doctrine/migrations                 v1.8.1             Database Schema migrations using Doctrine DBAL
doctrine/orm                        v2.6.1             Object-Relational-Mapper for PHP
facebook/webdriver                  1.6.0              A PHP client for Selenium WebDriver
guzzlehttp/guzzle                   6.3.3              Guzzle is a PHP HTTP client library
guzzlehttp/promises                 v1.3.1             Guzzle promises library
guzzlehttp/psr7                     1.4.2              PSR-7 message implementation that also provides common utility methods
jdorn/sql-formatter                 v1.2.17            a PHP SQL highlighting library
league/tactician                    v1.0.3             A small, flexible command bus. Handy for building service layers.
league/tactician-bundle             v1.1.5             Bundle to integrate Tactician with Symfony projects
league/tactician-container          2.0.0              Tactician integration for any container implementing PSR-11
league/tactician-logger             v0.10.0            Adds PSR-3 logging support to the Tactician command bus
myclabs/deep-copy                   1.8.1              Create deep copies (clones) of your objects
ocramius/package-versions           1.3.0              Composer plugin that provides efficient querying for installed package versions (no runtime IO)
ocramius/proxy-manager              2.1.1              A library providing utilities to generate, instantiate and generally operate with Object Proxies
paragonie/random_compat             v2.0.15            PHP 5.x polyfill for random_bytes() and random_int() from PHP 7
phar-io/manifest                    1.0.1              Component for reading phar.io manifest information from a PHP Archive (PHAR)
phar-io/version                     1.0.1              Library for handling version information and constraints
phpdocumentor/reflection-common     1.0.1              Common reflection classes used by phpdocumentor to reflect the code structure
phpdocumentor/reflection-docblock   4.3.0              With this component, a library can provide support for annotations via DocBlocks or otherwise retrieve information that is embedded in a DocBlock.
phpdocumentor/type-resolver         0.4.0             
phpspec/prophecy                    1.7.6              Highly opinionated mocking framework for PHP 5.3+
phpunit/php-code-coverage           6.0.5              Library that provides collection, processing, and rendering functionality for PHP code coverage information.
phpunit/php-file-iterator           1.4.5              FilterIterator implementation that filters files based on a list of suffixes.
phpunit/php-text-template           1.2.1              Simple template engine.
phpunit/php-timer                   2.0.0              Utility class for timing
phpunit/php-token-stream            3.0.0              Wrapper around PHP's tokenizer extension.
phpunit/phpunit                     7.1.5              The PHP Unit Testing framework.
phpunit/phpunit-mock-objects        6.1.2              Mock Object library for PHPUnit
psr/cache                           1.0.1              Common interface for caching libraries
psr/container                       1.0.0              Common Container Interface (PHP FIG PSR-11)
psr/http-message                    1.0.1              Common interface for HTTP messages
psr/log                             1.0.2              Common interface for logging libraries
psr/simple-cache                    1.0.1              Common interfaces for simple caching
ramsey/uuid                         3.7.3              Formerly rhumsaa/uuid. A PHP 5.4+ library for generating RFC 4122 version 1, 3, 4, and 5 universally unique identifiers (UUID).
sebastian/code-unit-reverse-lookup  1.0.1              Looks up which function or method a line of code belongs to
sebastian/comparator                3.0.1              Provides the functionality to compare PHP values for equality
sebastian/diff                      3.0.1              Diff implementation
sebastian/environment               3.1.0              Provides functionality to handle HHVM/PHP environments
sebastian/exporter                  3.1.0              Provides the functionality to export PHP variables for visualization
sebastian/global-state              2.0.0              Snapshotting of global state
sebastian/object-enumerator         3.0.3              Traverses array structures and object graphs to enumerate all referenced objects
sebastian/object-reflector          1.1.1              Allows reflection of object attributes, including inherited and non-public ones
sebastian/recursion-context         3.0.0              Provides functionality to recursively process PHP variables
sebastian/resource-operations       1.0.0              Provides a list of PHP built-in functions that operate on resources
sebastian/version                   2.0.1              Library that helps with managing the version number of Git-hosted PHP projects
symfony/browser-kit                 v4.1.0             Symfony BrowserKit Component
symfony/cache                       v4.1.0             Symfony Cache component with PSR-6, PSR-16, and tags
symfony/config                      v4.1.0             Symfony Config Component
symfony/console                     v4.1.0             Symfony Console Component
symfony/css-selector                v4.1.0             Symfony CssSelector Component
symfony/debug                       v4.1.0             Symfony Debug Component
symfony/dependency-injection        v4.1.0             Symfony DependencyInjection Component
symfony/doctrine-bridge             v4.1.0             Symfony Doctrine Bridge
symfony/dom-crawler                 v4.1.0             Symfony DomCrawler Component
symfony/dotenv                      v4.1.0             Registers environment variables from a .env file
symfony/event-dispatcher            v4.1.0             Symfony EventDispatcher Component
symfony/filesystem                  v4.1.0             Symfony Filesystem Component
symfony/finder                      v4.1.0             Symfony Finder Component
symfony/flex                        v1.0.80           
symfony/framework-bundle            v4.1.0             Symfony FrameworkBundle
symfony/http-foundation             v4.1.0             Symfony HttpFoundation Component
symfony/http-kernel                 v4.1.0             Symfony HttpKernel Component
symfony/lts                         dev-master 6de50b2 Enforces Long Term Supported versions of Symfony components
symfony/orm-pack                    v1.0.5             A pack for the Doctrine ORM
symfony/phpunit-bridge              v4.1.0             Symfony PHPUnit Bridge
symfony/polyfill-mbstring           v1.8.0             Symfony polyfill for the Mbstring extension
symfony/process                     v4.1.0             Symfony Process Component
symfony/routing                     v4.1.0             Symfony Routing Component
symfony/yaml                        v4.1.0             Symfony Yaml Component
theseer/tokenizer                   1.1.0              A small library for converting tokenized PHP source code into XML and potentially other formats
webmozart/assert                    1.3.0              Assertions to validate method input/output with nice error messages.
zendframework/zend-code             3.3.0              provides facilities to generate arbitrary code using an object oriented interface
zendframework/zend-eventmanager     3.2.1              Trigger and listen to events within a PHP application

And the composer.json:

{
    "require": {
        "php": "^7.1.3",
        "ext-ctype": "*",
        "ext-iconv": "*",
        "league/tactician-bundle": "^1.1",
        "ramsey/uuid": "^3.7",
        "symfony/console": "^4.1",
        "symfony/flex": "^1.0",
        "symfony/framework-bundle": "^4.1",
        "symfony/lts": "^4@dev",
        "symfony/orm-pack": "^1.0",
        "symfony/yaml": "^4.1"
    },
    "require-dev": {
        "codeception/codeception": "^2.4",
        "symfony/dotenv": "^4.1",
        "symfony/phpunit-bridge": "^4.1"
    }
}
ghost

ghost commented on Jun 22, 2018

@ghost
ghost
on Jun 22, 2018

Hi, we have the same problem here:

bin/phpunit
#!/usr/bin/env php
PHP Fatal error:  Declaration of Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7::addError(PHPUnit\Framework\Test $test, Throwable $t, float $time): void must be compatible with PHPUnit\Framework\TestListener::addError(PHPUnit\Framework\Test $test, Exception $e, $time)

Here is the composer show output:

composer/semver                    1.4.2   Semver library that offers utilities, version constraint parsing and validation.
composer/xdebug-handler            1.1.0   Restarts a process without xdebug.
doctrine/annotations               v1.6.0  Docblock Annotations Parser
doctrine/cache                     v1.7.1  Caching library offering an object-oriented API for many cache backends
doctrine/collections               v1.5.0  Collections Abstraction library
doctrine/common                    v2.8.1  Common Library for Doctrine projects
doctrine/dbal                      v2.7.1  Database Abstraction Layer
doctrine/doctrine-bundle           1.9.1   Symfony DoctrineBundle
doctrine/doctrine-cache-bundle     1.3.3   Symfony Bundle for Doctrine Cache
doctrine/inflector                 v1.3.0  Common String Manipulations with regard to casing and singular/plural rules.
doctrine/instantiator              1.1.0   A small, lightweight utility to instantiate objects in PHP without invoking their constructors
doctrine/lexer                     v1.0.1  Base library for a lexer that can be used in Top-Down, Recursive Descent Parsers.
doctrine/orm                       v2.6.1  Object-Relational-Mapper for PHP
friendsofphp/php-cs-fixer          v2.12.1 A tool to automatically fix PHP code style
guzzlehttp/guzzle                  5.3.2   Guzzle is a PHP HTTP client library and framework for building RESTful web service clients
guzzlehttp/ringphp                 1.1.0   Provides a simple API and specification that abstracts away the details of HTTP into a single PHP function.
guzzlehttp/streams                 3.0.0   Provides a simple abstraction over streams of data
jdorn/sql-formatter                v1.2.17 a PHP SQL highlighting library
jms/metadata                       1.6.0   Class/method/property metadata management in PHP
jms/parser-lib                     1.0.0   A library for easily creating recursive-descent parsers.
jms/serializer                     1.12.1  Library for (de-)serializing data of any complexity; supports XML, JSON, and YAML.
jms/serializer-bundle              2.4.1   Allows you to easily serialize, and deserialize data of any complexity
monolog/monolog                    1.23.0  Sends your logs to files, sockets, inboxes, databases and various web services
myclabs/deep-copy                  1.8.1   Create deep copies (clones) of your objects
nannehuiges/jsend                  v2.1.0  A simple PHP implementation of the JSend specification.
pagerfanta/pagerfanta              v1.1.0  Pagination for PHP 5.3
phar-io/manifest                   1.0.1   Component for reading phar.io manifest information from a PHP Archive (PHAR)
phar-io/version                    1.0.1   Library for handling version information and constraints
php-cs-fixer/diff                  v1.3.0  sebastian/diff v2 backport support for PHP5.6
phpcollection/phpcollection        0.5.0   General-Purpose Collection Library for PHP
phpdocumentor/reflection-common    1.0.1   Common reflection classes used by phpdocumentor to reflect the code structure
phpdocumentor/reflection-docblock  4.3.0   With this component, a library can provide support for annotations via DocBlocks or otherwise retrieve information that is embedde...
phpdocumentor/type-resolver        0.4.0
phpoption/phpoption                1.5.0   Option Type for PHP
phpro/soap-client                  0.7.3   A general purpose SoapClient library
phpspec/prophecy                   1.7.6   Highly opinionated mocking framework for PHP 5.3+
phpunit/php-code-coverage          6.0.7   Library that provides collection, processing, and rendering functionality for PHP code coverage information.
phpunit/php-file-iterator          2.0.1   FilterIterator implementation that filters files based on a list of suffixes.
phpunit/php-text-template          1.2.1   Simple template engine.
phpunit/php-timer                  2.0.0   Utility class for timing
phpunit/php-token-stream           3.0.0   Wrapper around PHP's tokenizer extension.
phpunit/phpunit                    7.2.6   The PHP Unit Testing framework.
psr/cache                          1.0.1   Common interface for caching libraries
psr/container                      1.0.0   Common Container Interface (PHP FIG PSR-11)
psr/log                            1.0.2   Common interface for logging libraries
psr/simple-cache                   1.0.1   Common interfaces for simple caching
react/promise                      v2.7.0  A lightweight implementation of CommonJS Promises/A for PHP
sebastian/code-unit-reverse-lookup 1.0.1   Looks up which function or method a line of code belongs to
sebastian/comparator               3.0.1   Provides the functionality to compare PHP values for equality
sebastian/diff                     3.0.1   Diff implementation
sebastian/environment              3.1.0   Provides functionality to handle HHVM/PHP environments
sebastian/exporter                 3.1.0   Provides the functionality to export PHP variables for visualization
sebastian/global-state             2.0.0   Snapshotting of global state
sebastian/object-enumerator        3.0.3   Traverses array structures and object graphs to enumerate all referenced objects
sebastian/object-reflector         1.1.1   Allows reflection of object attributes, including inherited and non-public ones
sebastian/recursion-context        3.0.0   Provides functionality to recursively process PHP variables
sebastian/resource-operations      1.0.0   Provides a list of PHP built-in functions that operate on resources
sebastian/version                  2.0.1   Library that helps with managing the version number of Git-hosted PHP projects
squizlabs/php_codesniffer          2.9.1   PHP_CodeSniffer tokenizes PHP, JavaScript and CSS files and detects violations of a defined set of coding standards.
symfony/cache                      v4.1.0  Symfony Cache component with PSR-6, PSR-16, and tags
symfony/config                     v4.1.0  Symfony Config Component
symfony/console                    v4.1.0  Symfony Console Component
symfony/debug                      v4.1.0  Symfony Debug Component
symfony/dependency-injection       v4.1.0  Symfony DependencyInjection Component
symfony/doctrine-bridge            v4.1.0  Symfony Doctrine Bridge
symfony/dotenv                     v4.1.0  Registers environment variables from a .env file
symfony/event-dispatcher           v4.1.0  Symfony EventDispatcher Component
symfony/filesystem                 v4.1.0  Symfony Filesystem Component
symfony/finder                     v4.1.0  Symfony Finder Component
symfony/flex                       v1.0.80
symfony/form                       v4.1.0  Symfony Form Component
symfony/framework-bundle           v4.1.0  Symfony FrameworkBundle
symfony/http-foundation            v4.1.0  Symfony HttpFoundation Component
symfony/http-kernel                v4.1.0  Symfony HttpKernel Component
symfony/inflector                  v4.1.0  Symfony Inflector Component
symfony/intl                       v4.1.0  A PHP replacement layer for the C intl extension that includes additional data from the ICU library.
symfony/monolog-bridge             v4.1.0  Symfony Monolog Bridge
symfony/monolog-bundle             v3.3.0  Symfony MonologBundle
symfony/options-resolver           v4.1.0  Symfony OptionsResolver Component
symfony/phpunit-bridge             v4.1.0  Symfony PHPUnit Bridge
symfony/polyfill-ctype             v1.8.0  Symfony polyfill for ctype functions
symfony/polyfill-intl-icu          v1.8.0  Symfony polyfill for intl's ICU-related data and classes
symfony/polyfill-mbstring          v1.8.0  Symfony polyfill for the Mbstring extension
symfony/polyfill-php72             v1.8.0  Symfony polyfill backporting some PHP 7.2+ features to lower PHP versions
symfony/process                    v4.1.0  Symfony Process Component
symfony/property-access            v4.1.0  Symfony PropertyAccess Component
symfony/routing                    v4.1.0  Symfony Routing Component
symfony/stopwatch                  v4.1.0  Symfony Stopwatch Component
symfony/translation                v4.1.0  Symfony Translation Component
symfony/validator                  v4.1.0  Symfony Validator Component
symfony/yaml                       v4.1.0  Symfony Yaml Component
theseer/tokenizer                  1.1.0   A small library for converting tokenized PHP source code into XML and potentially other formats
webmozart/assert                   1.3.0   Assertions to validate method input/output with nice error messages.
wimg/php-compatibility             7.1.5   This is a set of sniffs for PHP_CodeSniffer that checks for PHP version compatibility.
zendframework/zend-code            3.3.0   provides facilities to generate arbitrary code using an object oriented interface
zendframework/zend-eventmanager    3.2.1   Trigger and listen to events within a PHP application

And this is what we have in composer.json:

    "require": {
        "php": "^7.2",
        "ext-iconv": "*",
        "doctrine/doctrine-bundle": "^1.9",
        "phpro/soap-client": "^0.7.2",
        "symfony/console": "^4.1",
        "symfony/flex": "^1.0",
        "symfony/framework-bundle": "^4.1",
        "symfony/yaml": "^4.1"
    },
    "require-dev": {
        "symfony/dotenv": "^4.1",
        "symfony/phpunit-bridge": "^4.1",
        "zendframework/zend-code": "^3.1.0"
    },

Looking forward to some help on that topic.

nicolas-grekas

nicolas-grekas commented on Jun 23, 2018

@nicolas-grekas
nicolas-grekas
on Jun 23, 2018
Member

You need to use the real phpunit script instead, which is at ./vendor/bin/phpunit.

xabbuh

xabbuh commented on Jul 6, 2018

@xabbuh
xabbuh
on Jul 6, 2018
Member

Is there anything we need to do here?

ostrolucky

ostrolucky commented on Jul 7, 2018

@ostrolucky
ostrolucky
on Jul 7, 2018
Contributor

Well yes, this issue is about composer triggering the message when requiring libs relying on phpunit. @nicolas-grekas's comment solves different issue.

22 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugPhpUnitBridgeStatus: Needs ReviewStatus: Waiting feedback

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @nicolas-grekas@gnutix@sinner@stof@DavidBadura

        Issue actions
          Composer warning when installing Codeception: "Adding phpunit/phpunit as a dependency is discouraged in favor of Symfony's PHPUnit Bridge" · Issue #27289 · symfony/symfony