Adding a new debug:autowiring command #24583
Conversation
weaverryan
force-pushed
the
debug-autowiring
branch
from
30a7548
to
41df512
Compare
|
The class the alias points to would be interesting |
|
We need to remove the |
|
This would be really great to have in 3.4 |
There was a problem hiding this comment.
This is really nice. I like it!
My only concern is forward compatibility with #24562. If we add a "debug:services" command soon ... should this one be merged with it and renamed as debug:Services? Should this be an independent command? Thanks!
| $this | ||
| ->setDefinition(array( | ||
| new InputArgument('search', InputArgument::OPTIONAL, 'A search filter'), | ||
| )) |
There was a problem hiding this comment.
this command should have a format option, for people wanting to do some scripting (we generally don't guarantee stability on the text format for usage with |grep`, as this would forbid us to improve DX, but then it requires having other formats)
There was a problem hiding this comment.
I did this on purpose. I really want this command. But I also realize that it's after feature freeze, and things might change with debug:container or debug:services in the future. I don't want to encourage (right now) that people use this for scripting. Also, they can use debug:container --types and pass a format.
| /** | ||
| * @group functional | ||
| */ | ||
| class DebugAutowiringCommandTest extends WebTestCase |
There was a problem hiding this comment.
you should use KernelTestCase only, as you don't care about the web part (you won't use a BrowserKit client).
There was a problem hiding this comment.
I think it's correct actually: this WebTestCase lives right in this same Functional directory and all the other tests (including those for other commands) use it - it helps setup the temp kernel/project I believe. Changing to KernelTestCase made things blow up.
There was a problem hiding this comment.
ah, I missed that this is the special WebTestCase from the FrameworkBundle testsuite, not the one exposed to users of Symfony
I'd like to keep it, and remove it later when we've thought more about what to do with the
I think I still like the independent All comments addressed! |
|
Thank you @weaverryan. |
This PR was merged into the 3.4 branch. Discussion ---------- Adding a new debug:autowiring command | Q | A | ------------- | --- | Branch? | 3.4 (if I can make my case, otherwise 4.1) | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21222 and #24562 partially | License | MIT | Doc PR | TODO Very simply, this adds a proper `debug:autowiring`, which is much shorter / nicer than `debug:container --types` and much prettier. Before (`debug:container --types`): <img width="1280" alt="screen shot 2017-10-16 at 8 28 05 pm" src="https://user-images.githubusercontent.com/121003/31641112-931c84ca-b2b0-11e7-9432-136ecf47ed0f.png"> <img width="1280" alt="screen shot 2017-10-16 at 8 28 18 pm" src="https://user-images.githubusercontent.com/121003/31641113-932ac1fc-b2b0-11e7-8a65-34199c9933c1.png"> After (`debug:autowiring`) <img width="1131" alt="screen shot 2017-10-16 at 7 58 06 pm" src="https://user-images.githubusercontent.com/121003/31641124-a3288a6c-b2b0-11e7-8255-a8e676a26aba.png"> <img width="1101" alt="screen shot 2017-10-16 at 7 58 16 pm" src="https://user-images.githubusercontent.com/121003/31641125-a334c354-b2b0-11e7-8ee3-3bbad5678a1a.png"> The command is purposely simple: no special powers, no magic (other than a `search` argument), just a clean list and nice output. I would love to sneak this in for 3.4, but I understand either way. Commits ------- 41df512 Adding a new debug:autowiring command
Very simply, this adds a proper
debug:autowiring, which is much shorter / nicer thandebug:container --typesand much prettier.Before (
debug:container --types):After (
debug:autowiring)The command is purposely simple: no special powers, no magic (other than a
searchargument), just a clean list and nice output.I would love to sneak this in for 3.4, but I understand either way.