[Form] invalidate forms on transformation failures #28731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 4, 2018
•
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20916, #21242, #28584 |
| License | MIT |
| Doc PR |
xabbuh
force-pushed
the
issue-20916
branch
4 times, most recently
from
b7df8b9
to
6cf76d1
Compare
xabbuh
changed the title
|
Test added, PR is ready from my POV |
yceruto
reviewed
Nov 1, 2018
| $message = 'This value is not valid.'; | ||
|
|
||
| if (null !== $this->translator) { | ||
| $message = $this->translator->trans($message, array('{{ value }}' => $clientDataAsString)); |
There was a problem hiding this comment.
The message is static then shouldn't the placeholder be there? ->trans('This value {{ value }} is not valid.', array('{{ value }}' => $clientDataAsString)) ?
There was a problem hiding this comment.
fixed, thanks for catching it
| $message = $this->translator->trans($message, array('{{ value }}' => $clientDataAsString)); | ||
| } | ||
|
|
||
| $form->addError(new FormError($message, 'This value is not valid.', array('{{ value }}' => $clientDataAsString), null, $form->getTransformationFailure())); |
There was a problem hiding this comment.
Same here for the message template (2nd argument)
src/Symfony/Component/Form/Extension/Core/Type/TransformationFailureExtension.php
Show resolved
Hide resolved
|
ping @symfony/deciders :) |
ostrolucky
reviewed
Nov 10, 2018
| foreach ($form as $child) { | ||
| if (!$child->isSynchronized()) { | ||
| $childrenSynchronized = false; | ||
| break; |
There was a problem hiding this comment.
Would be more elegant to just return here. Then you wouldn't need $childrenSynchronized variable and guard it later at all
ostrolucky
approved these changes
Nov 11, 2018
fabpot
approved these changes
Nov 12, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 12, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Form] invalidate forms on transformation failures | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20916, #21242, #28584 | License | MIT | Doc PR | Commits ------- 385d9df invalidate forms on transformation failures
Merged
This was referenced Nov 26, 2018
Merged
Merged
Merged
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.