[Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS #29131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see also |
|
the commands don't care about thread safety: they never run in an IIS thread. |
stof
approved these changes
Nov 8, 2018
nicolas-grekas
force-pushed
the
dotenv-up
branch
from
64c3eb0
to
b52040d
Compare
chalasr
approved these changes
Nov 8, 2018
nicolas-grekas
force-pushed
the
dotenv-up
branch
from
b52040d
to
21a909a
Compare
dunglas
approved these changes
Nov 8, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2018
…colas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Since using it is not thread safe, let's not rely on it (already done in other places.) Commits ------- 21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
Merged
fabpot
added a commit
that referenced
this pull request
Aug 30, 2019
…(brentybh) This PR was squashed before being merged into the 4.3 branch (closes #33357). Discussion ---------- [FrameworkBundle] Fix about command not showing .env vars Before this fix, `bin/console about` can't properly show `Environment (.env)` section because: `SYMFONY_DOTENV_VARS` which stores all keys of Dotenv-set env vars, is being fetched via `getenv()`. However, in Symfony Dotenv 4.3, usage of `putenv()` is deprecated: symfony/dotenv@d2fa94d#diff-a6967492da82dce9ba93bcba3eee0334 so we can get env vars via `getenv()` only when `new Dotenv(true)`. In the default shipped `config/bootstrap.php`, there is `new Dotenv(false)` set. (Maybe related #29131) | Q | A | ------------- | --- | Branch? | 4.3 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- f48f19d [FrameworkBundle] Fix about command not showing .env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since using it is not thread safe, let's not rely on it (already done in other places.)