PropertyInfoLoader should not try to add validation to non-existent property #31936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
no-auto-validation-on-non-existent-prop
branch
from
4af9fa1
to
89f72a1
Compare
xabbuh
approved these changes
Jun 7, 2019
weaverryan
commented
Jun 7, 2019
| @@ -60,6 +60,10 @@ public function loadClassMetadata(ClassMetadata $metadata) | |||
| continue; | |||
| } | |||
|
|
|||
| if (false === property_exists($className, $property)) { | |||
There was a problem hiding this comment.
property_exists() is what is used in PropertyMetadata, which triggered the exception. This matches that.
| @@ -46,6 +46,7 @@ public function testLoadClassMetadata() | |||
| 'alreadyMappedNotBlank', | |||
| 'alreadyPartiallyMappedCollection', | |||
| 'readOnly', | |||
| 'nonExistentField', | |||
There was a problem hiding this comment.
No asserts were added, but, without the fix, these changes are enough to trigger an exception to be thrown while running this test.
Simperfit
approved these changes
Jun 7, 2019
…istent properties
weaverryan
force-pushed
the
no-auto-validation-on-non-existent-prop
branch
from
89f72a1
to
b702598
Compare
|
Thank you @weaverryan. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 7, 2019
…-existent property (weaverryan) This PR was merged into the 4.3 branch. Discussion ---------- PropertyInfoLoader should not try to add validation to non-existent property | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31796 (see #31796 (comment)) | License | MIT | Doc PR | not needed With auto-validation, if a class has a setter (e.g. `setFoo()`) but there is no `foo` property, it still tries to add validation to that property, resulting in a: > Property "foo" does not exist in class "App\Entity\Bar This fixes that. I believe it's "just this simple", but I don't have any experience with the code in this area yet. Cheers! Commits ------- b702598 Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
|
Looks good to me! Thank you Ryan. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With auto-validation, if a class has a setter (e.g.
setFoo()) but there is nofooproperty, it still tries to add validation to that property, resulting in a:This fixes that. I believe it's "just this simple", but I don't have any experience with the code in this area yet.
Cheers!