[Mime] Remove NamedAddress #33270
Merged
[Mime] Remove NamedAddress #33270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
force-pushed
the
named-address-removal
branch
from
29a2495
to
240feb0
Compare
fabpot
force-pushed
the
named-address-removal
branch
from
240feb0
to
eb7d74e
Compare
nicolas-grekas
approved these changes
Aug 21, 2019
fabpot
added a commit
that referenced
this pull request
Aug 21, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] Remove NamedAddress | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | yes <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | n/a While working on #33091, we realize that having both `NamedAddress` and `Address` brings some unneeded complexity. Initially, I added both as some headers do not support `NamedAddress`es. But the code already does the right thing by "downgrading" them to `Address` instances. So, let's simplify our internal code and make life easier for our users too. Commits ------- eb7d74e [Mime] Remove NamedAddress
stof
reviewed
Aug 21, 2019
| @@ -93,15 +90,15 @@ public function getReturnPath(): string | |||
| /** | |||
| * @return $this | |||
| */ | |||
| public function addFrom(string $address, string $name = null): self | |||
| public function addFrom(string $address, string $name = ''): self | |||
There was a problem hiding this comment.
this should be documented in the upgrade guide too, as the parameter type changed from string|null to string, which is also a BC break.
There was a problem hiding this comment.
The parameter type was string and null was only to express that no arguments was passed. Anyway, I think that's minor and we should not waste our time on such things.
stof
reviewed
Aug 21, 2019
| @@ -21,14 +21,15 @@ | |||
| /** | |||
| * @author Fabien Potencier <fabien@symfony.com> | |||
| */ | |||
| class Address | |||
| final class Address | |||
There was a problem hiding this comment.
this needs to be documented in the upgrade guide too, as it is a BC break.
| @@ -61,7 +68,7 @@ public function getEncodedAddress(): string | |||
|
|
|||
| public function toString(): string | |||
| { | |||
| return $this->getEncodedAddress(); | |||
| return ($n = $this->getName()) ? $n.' <'.$this->getEncodedAddress().'>' : $this->getEncodedAddress(); | |||
There was a problem hiding this comment.
use $this->name directly rather than adding another variable.
This was referenced Oct 18, 2019
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 18, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][Mime] NamedAddress was removed in 4.4 It was removed in 4.4 (symfony/symfony#33270) in favor of using Address with a second arg. Commits ------- 9b6eb23 [Mailer][Mime] NamedAddress was removed in 4.4
fabpot
added a commit
that referenced
this pull request
Oct 18, 2019
…(ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer][MailchimpBridge] Fix NamedAddress obsolete paths | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | N/A <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | N/A As NamedAddress was removed in #33270 (4.4) and this bridge does require `symfony/mailer >= 4.4`. Commits ------- f14d082 [Mailer][MailchimpBridge] Fix NamedAddress obsolete paths
This was referenced Nov 12, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #33091, we realizes that having both
NamedAddressandAddressbrings some unneeded complexity. Initially, I added both as some headers do not supportNamedAddresses. But the code already does the right thing by "downgrading" them toAddressinstances. So, let's simplify our internal code and make life easier for our users too.