[MonologBridge] Add Mailer handler #33456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BoShurik
commented
Sep 4, 2019
•
BoShurik
commented
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #33209 |
| License | MIT |
| Doc PR | - |
|
@stof done, but not sure why build fails. Looks like unrelated |
fabpot
requested changes
Sep 5, 2019
fabpot
requested changes
Sep 5, 2019
weaverryan
reviewed
Oct 28, 2019
|
Proposing this for the 4.4 milestone so that this doesn't block Mailer as a first-class citizen in 4.4/5.0 |
nicolas-grekas
changed the title
|
Any news here? I guess a PR to monolog-bundle would be also needed? |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 17, 2019
…nolog (javiereguiluz) This PR was merged into the 4.3 branch. Discussion ---------- [Monolog] Add a caution note about Symfony Mailer and Monolog We can't fix #12758 properly until this is fixed in symfony/symfony#33456 but meanwhile we can display a caution message to avoid confusion. Commits ------- 82119af [Monolog] Add a caution note about Symfony Mailer and Monolog
|
Any update here? It's the last reason we are still on swiftmailer. :/ |
|
Hi @BoShurik, how can I help to get this for 5.1? Thank you, |
|
@noniagriconomie Hi! Sorry for delay. I'll add changes by the end of the week |
BoShurik
commented
Jan 16, 2020
|
Needs a review |
fabpot
approved these changes
Feb 8, 2020
|
Thank you @BoShurik. |
fabpot
added a commit
that referenced
this pull request
Feb 8, 2020
This PR was merged into the 5.1-dev branch. Discussion ---------- [MonologBridge] Add Mailer handler | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #33209 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - <!-- required for new features --> <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/roadmap): - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against branch 4.4. - Legacy code removals go to the master branch. --> Commits ------- 5b7393b Add monolog mailer handler
Merged
|
As many others, this is the last reason we use SwiftMailer. Is there any chance this will be merged into SF 4.4? |
|
@Schyzophrenic No, new features are never backported. |
lyrixx
added a commit
to symfony/monolog-bundle
that referenced
this pull request
Oct 2, 2020
This PR was squashed before being merged into the 3.x-dev branch. Discussion ---------- Add Symfony Mailer support Add support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge on symfony/symfony#33456 Also this can make symfony/symfony-docs#13077 move forward Tests are failing due to incompatible phpunit versions, not sure how to fix this... Commits ------- 4bea89c Add Symfony Mailer support
javiereguiluz
added a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Oct 7, 2020
…(noniagriconomie, OskarStark) This PR was merged into the 5.1 branch. Discussion ---------- Document usage of Symfony Mailer for error email Related to symfony/monolog-bundle#354 and symfony/monolog-bundle#354 (comment) ---------- Should we also document that for the `v4.4` of this page, it will not be possible? The `Symfony\Bridge\Monolog\Handler\MailerHandler` was added in `v5.1` (symfony/symfony#33456) Because the wording `compatible yet` implies that it will be compatible in the future Thank you edit: I do not understand the `DOCtor-RST` check here :s Commits ------- 202b9e6 Update message d20f07c Fix: DOXtor-RST 922932f Makes DOCtor-RST happy 3df4d9e Document usage of Symfony Mailer for error email
|
How to use MailerHandler without framework ? |
dani-danigm
pushed a commit
to dani-danigm/monolog-bundle
that referenced
this pull request
Jun 15, 2022
This PR was squashed before being merged into the 3.x-dev branch. Discussion ---------- Add Symfony Mailer support Add support for the new symfony mailer directly on the bundle after the MailerHandle was added to the bridge on symfony/symfony#33456 Also this can make symfony/symfony-docs#13077 move forward Tests are failing due to incompatible phpunit versions, not sure how to fix this... Commits ------- 0b832f2 Add Symfony Mailer support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.