Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mailer][Messenger] add return statement for MessageHandler #36424

Merged
merged 1 commit into from Apr 13, 2020
Merged

[Mailer][Messenger] add return statement for MessageHandler #36424

merged 1 commit into from Apr 13, 2020

Conversation

ottaviano
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

By returning the result of the transporter in MessageHandler we can get hold of SentMessage from HandledStamp::getResult().
image

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 12, 2020
@nicolas-grekas
Copy link
Member

Can you add a test case please? Did you have a look at other handlers that might need the same?

@fabpot
Copy link
Member

fabpot commented Apr 13, 2020

Thank you @ottaviano.

@fabpot fabpot merged commit 0933f90 into symfony:master Apr 13, 2020
This was referenced Apr 13, 2020
Closed
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.1 May 4, 2020
@fabpot fabpot mentioned this pull request May 5, 2020
Merged
@mbabker mbabker mentioned this pull request Jun 23, 2020
Merged
1 task
@pableu pableu mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Messenger Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ottaviano @nicolas-grekas @fabpot @carsonbot