Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] properly cascade validation to child forms #37085

Merged
merged 1 commit into from Jun 4, 2020
Merged

[Form] properly cascade validation to child forms #37085

merged 1 commit into from Jun 4, 2020

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 3, 2020 •
edited by nicolas-grekas

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #37025, Fix #37027
License MIT
Doc PR

TODO:

  • improve test coverage

@xabbuh xabbuh added this to the 3.4 milestone Jun 3, 2020
This was referenced Jun 3, 2020
Closed
Closed
Closed
xabbuh referenced this pull request Jun 4, 2020
@xabbuh
validate subforms in all validation groups
b819d94
@xabbuh
Copy link
Member Author

xabbuh commented Jun 4, 2020

Status: Needs Review

@xabbuh xabbuh mentioned this pull request Jun 4, 2020
Closed
@fabpot
Copy link
Member

fabpot commented Jun 4, 2020

Thank you @xabbuh.

@fabpot fabpot merged commit 3e0330f into symfony:3.4 Jun 4, 2020
@xabbuh xabbuh deleted the issue-37025 branch June 4, 2020 12:43
This was referenced Jun 4, 2020
Closed
Closed
This was referenced Jun 12, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xabbuh @fabpot @nicolas-grekas @carsonbot