Add annotation with proper types for entity properties #394
Conversation
|
I also wonder about using |
|
If we add the |
| @@ -22,56 +22,74 @@ | |||
| class Post | |||
| { | |||
| /** | |||
| * @var int | |||
There was a problem hiding this comment.
useless for constants. The IDE already reads the value anyway. A constant is not a variable
There was a problem hiding this comment.
Reverted.
Thanks, Christophe!
bocharsky-bw
force-pushed
the
properties-types
branch
from
3ebed1c
to
08790e1
Compare
|
When the properties are annotated, you shouldn't have to repeat the type for the returned values of the getter methods as IDEs are able to infer the return types then. |
| public function getPublishedAt() | ||
| { | ||
| return $this->publishedAt; | ||
| } | ||
|
|
||
| /** | ||
| * @param \DateTime $publishedAt |
There was a problem hiding this comment.
not needed as the type hint already provides this information
|
@xabbuh Do you suggest to fully revert commit about annotations for setters / getters? |
|
@bocharsky-bw For setters where we do not have type hints (i.e. scalar type arguments) we should keep them. |
|
@bocharsky-bw thanks for proposing this improvement. I love it when we make our code more consistent and IDE-friendly. Thanks! |
…ency pov" (bocharsky-bw) This PR was merged into the master branch. Discussion ---------- Revert "Updated the DocBlocks of the Entities from consistency pov" This reverts #527 The reasons were described earlier in #394 Commits ------- 88d2100 Revert "Updated the DocBlocks of the Entities from consistency point of view."
The most IDEs start showing returned types on getter calls after these changes.