Upgrading all packages to Stimulus 3 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
stimulus3
branch
4 times, most recently
from
f4438b9
to
1c31d7e
Compare
|
This is ready. Along with: |
weaverryan
commented
Sep 29, 2021
|
Hello, What can one do to help move this along ? There's a few things in Stimulus 3 that would make my life easier (namely the XXXTargetAdded events). I'd be willing to help if it's in my range of competences and help is required in anyway. |
1 task
weaverryan
force-pushed
the
stimulus3
branch
4 times, most recently
from
4cfb44e
to
a96daa0
Compare
This was referenced Nov 8, 2021
Merged
kbond
added a commit
that referenced
this pull request
Nov 21, 2021
This PR was merged into the main branch. Discussion ---------- Allowing Symfony 6 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | Tickets | None | License | MIT We have an upcoming new major version (see #141), but I think we should support Symfony 6 in a minor release before that. Cheers! Commits ------- dd97519 allowing panther2 fe122ee [TwigComponent] add test container bc layer & latest zenstruck/browser 605a7bf allowing Symfony 6
weaverryan
force-pushed
the
stimulus3
branch
8 times, most recently
from
c5b2f08
to
b1ec7e1
Compare
tgalopin
approved these changes
Nov 25, 2021
|
Thanks @weaverryan. |
Closed
tgalopin
added a commit
that referenced
this pull request
Nov 29, 2021
This PR was squashed before being merged into the main branch. Discussion ---------- Using Typescript & Centralizing Builds | Q | A | ------------- | --- | Bug fix? | No | New feature? | Yes | Tickets | None | License | MIT **Depends on #141** Hi! This PR converts the project to use TypeScript, but that in itself wasn't really the motivation. ## Motivations / Changes * A) Standardize how we do things to be more like ``@hotwired`/stimulus` and other high-quality Stimulus libraries (like `stimulus-use` * B) Centralize the build processes: the "build", "test" and "lint" processes are now all centralized so that each "library" can focus on just doing its job. * C) This **removes support for IE11** (see below). B) Was the main motivator - before, each library was responsible for setting up their own test process and (more importantly) their own build process, which allowed for inconsistencies for what transformations we make, etc. ## IE 11 Support Gone Stimulus 3 dropped IE 11 support. This PR would be released with the version of Symfony UX that starts using Stimulus 3. So, we follow suit. It makes the builds smaller and makes (along with Typescript) our build process MUCH simpler. It's pretty easy to see the difference in the built files - for example https://github.com/symfony/ux/pull/156/files#diff-72060cc03a17f489a2c7e84dd42fab25c7d19ee5154f0c493f00b91d6a13285b ## TODOS * [ ] Some additional cleanup so that the TypeScript build process finishes without warnings (it already finishes without errors). Commits ------- f8eb843 Using Typescript & Centralizing Builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Pretty simple, except that it will, unfortunately, require a new major release.
This also included a few Symfony 6 compat things in tests.
TODOs:
See #161 for tasks related to the 2.0 release.